-
Notifications
You must be signed in to change notification settings - Fork 29
Feature export/import study (backend) #2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2053 +/- ##
========================================
+ Coverage 73.3% 73.7% +0.4%
========================================
Files 421 436 +15
Lines 15487 16061 +574
Branches 1563 1614 +51
========================================
+ Hits 11357 11848 +491
- Misses 3719 3774 +55
- Partials 411 439 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…re-forked into feature-export-import
…re-forked into feature-export-import
…re-forked into feature-export-import
So this is OK, thanks for pointing it out. Had to bump a timeout form 5 minutes. The reply is correct 400, as intended in case of error during the download. Too bad I cannot see the response from the request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minors. but great work. looking forward to using that feature.
services/web/server/src/simcore_service_webserver/exporter/config.py
Outdated
Show resolved
Hide resolved
env_prefix = "WEBSERVER_EXPORTER_" | ||
|
||
|
||
exporter_settings = ExporterSettings() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be in the setup, as I mentioned above. We do not want to have globals. Instead we prefer singletons INSIDE the app. Nevermind, it is minor. I will change it later
What do these changes do?
Adds Import/export ability for studies.
What it brings:
Missing to do in future PRs:
Bonuses:
Related issue number
ITISFoundation/osparc-issues#325
How to test
Step 1: setup tools
(https://github.com/ITISFoundation/osparc-simcore/files/5738904/imp-exp.postman_collection.json.zip) NOTE: you need to unzip it
Step 2: exporting
Step 3: importing
Debugging import/export project data
From admirer export the original and imported project in csv format, you should get a file projects.csv (see setup below)

Use the following script to transform projects.csv to json files which are simpler to compare csv_to_json.py.zip
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)