-
Notifications
You must be signed in to change notification settings - Fork 28
bugfix: director-v2 is implicitely converting float values to int, preventing kember from running #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: director-v2 is implicitely converting float values to int, preventing kember from running #2081
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2081 +/- ##
======================================
Coverage 72.8% 72.9%
======================================
Files 421 421
Lines 15487 15487
Branches 1568 1568
======================================
+ Hits 11289 11304 +15
+ Misses 3791 3779 -12
+ Partials 407 404 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so annoying when this happens. I've also fixed this issue in my PR for exposing and importing services (if I did not revert it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are the fixes here? Did you forget to commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AHA! I see it now ... STRICT
What do these changes do?
Kember tutorial was failing because a wrong value of 0 is passed as deltaT to the kember service
Related issue/s
How to test
Checklist