Skip to content

bugfix: director-v2 is implicitely converting float values to int, preventing kember from running #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

What do these changes do?

Kember tutorial was failing because a wrong value of 0 is passed as deltaT to the kember service

Related issue/s

How to test

Checklist

@sanderegg sanderegg requested a review from KZzizzle January 11, 2021 17:05
@sanderegg sanderegg self-assigned this Jan 11, 2021
@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Jan 11, 2021
@sanderegg sanderegg added this to the Chronos milestone Jan 11, 2021
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #2081 (c70c752) into master (c19ebb0) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2081   +/-   ##
======================================
  Coverage    72.8%   72.9%           
======================================
  Files         421     421           
  Lines       15487   15487           
  Branches     1568    1568           
======================================
+ Hits        11289   11304   +15     
+ Misses       3791    3779   -12     
+ Partials      407     404    -3     
Flag Coverage Δ
integrationtests 63.7% <ø> (+0.1%) ⬆️
unittests 67.4% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...odels-library/src/models_library/projects_nodes.py 90.0% <100.0%> (ø)
...ce_webserver/resource_manager/garbage_collector.py 78.5% <0.0%> (+0.9%) ⬆️
...erver/src/simcore_service_webserver/director_v2.py 88.8% <0.0%> (+2.5%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 90.9% <0.0%> (+9.0%) ⬆️
..._service_webserver/projects/projects_exceptions.py 100.0% <0.0%> (+9.5%) ⬆️

Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so annoying when this happens. I've also fixed this issue in my PR for exposing and importing services (if I did not revert it)

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are the fixes here? Did you forget to commit?

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AHA! I see it now ... STRICT

@sanderegg sanderegg merged commit 83d08f7 into ITISFoundation:master Jan 12, 2021
@sanderegg sanderegg deleted the bugfix/incorrect_casting_to_int branch January 12, 2021 07:46
@sanderegg sanderegg mentioned this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants