Skip to content

More e2e tests #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 20, 2021
Merged

More e2e tests #2083

merged 20 commits into from
Jan 20, 2021

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 12, 2021

What do these changes do?

This PR adds two more tests:

  • Kember, which is part of the portal templates
  • isolve-gpu:2.0.71, which is part of the osparc-manual-z43 tutorials
    • Add templates to master (later to staging-dalco and production-dalco)
    • Add e2e test

Bonus

Related issue/s

closes #2082
closes #2074

@odeimaiz odeimaiz self-assigned this Jan 12, 2021
@odeimaiz odeimaiz added this to the Chronos milestone Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #2083 (e9e8c18) into master (d0b46e4) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2083     +/-   ##
========================================
- Coverage    73.0%   73.0%   -0.1%     
========================================
  Files         421     421             
  Lines       15486   15486             
  Branches     1569    1569             
========================================
- Hits        11316   11310      -6     
- Misses       3761    3764      +3     
- Partials      409     412      +3     
Flag Coverage Δ
integrationtests 63.5% <ø> (-0.1%) ⬇️
unittests 67.6% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...webserver/computation_comp_tasks_listening_task.py 85.2% <0.0%> (-5.7%) ⬇️
...simcore_service_webserver/projects/projects_api.py 84.6% <0.0%> (-0.5%) ⬇️

@odeimaiz odeimaiz changed the title More e2e tests WIP: More e2e tests Jan 12, 2021
@odeimaiz odeimaiz marked this pull request as draft January 12, 2021 16:48
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Jan 12, 2021
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Jan 15, 2021
@odeimaiz odeimaiz assigned mguidon and unassigned mguidon Jan 15, 2021
@odeimaiz odeimaiz marked this pull request as ready for review January 18, 2021 15:16
@odeimaiz odeimaiz changed the title WIP: More e2e tests More e2e tests Jan 18, 2021
Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful Odei, thanks for the added tests

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful. I will try to fix the kember soonish

@odeimaiz odeimaiz merged commit d652063 into ITISFoundation:master Jan 20, 2021
@sanderegg sanderegg mentioned this pull request Jan 29, 2021
@odeimaiz odeimaiz deleted the feature/more-e2e branch February 24, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add kember to p2p testing Cached calls accumulate over log in&out
4 participants