Toolbar with Breadcrumbs, improved Start/Stop and more #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2098 +/- ##
========================================
- Coverage 73.5% 73.5% -0.1%
========================================
Files 452 452
Lines 16704 16704
Branches 1661 1661
========================================
- Hits 12282 12280 -2
- Misses 3969 3971 +2
Partials 453 453
Flags with carried forward coverage won't be shown. Click here to find out more.
|
odeimaiz
changed the title
odeimaiz
changed the title
pcrespov
approved these changes
Jan 25, 2021
| for (let nodeId in slideShow) { | ||
| const node = slideShow[nodeId]; | ||
| nodes.push({ | ||
| ...node, |
There was a problem hiding this comment.
| }); | ||
| } | ||
| nodes.sort((a, b) => (a.position > b.position) ? 1 : -1); | ||
| const nodeIds = []; |
There was a problem hiding this comment.
strange language that defines a const can change it :-) I guess const prevent assignment but not chancing the content of the container. ... still strange :-)
There was a problem hiding this comment.
It is a const in the sense that can't be reassigned, but it is mutable:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Bonus
New toolbar:
Stop/Run (workbench):
Stop/Run (guided):
Quality by clicking the stars on card:
Related issue/s
related to ITISFoundation/osparc-issues#327
How to test
Checklist