Skip to content

e2e isolve fix: Start template instead of service #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2021
Merged

e2e isolve fix: Start template instead of service #2100

merged 2 commits into from
Jan 21, 2021

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 21, 2021 •
edited
Loading

e2e isolve fix: Start template instead of service

@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Jan 21, 2021
@odeimaiz odeimaiz added this to the Chronos milestone Jan 21, 2021
@odeimaiz odeimaiz self-assigned this Jan 21, 2021
@odeimaiz odeimaiz changed the title e2e fix: Start template instead of service e2e isolve fix: Start template instead of service Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #2100 (ad64f1f) into master (427ade8) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2100   +/-   ##
======================================
  Coverage    73.7%   73.7%           
======================================
  Files         436     436           
  Lines       16061   16061           
  Branches     1614    1614           
======================================
+ Hits        11848   11850    +2     
  Misses       3773    3773           
+ Partials      440     438    -2
Flag Coverage Δ
integrationtests 65.2% <ø> (+<0.1%) ⬆️
unittests 67.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/director_v2.py 86.4% <0.0%> (-2.6%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 77.5% <0.0%> (+0.9%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 90.9% <0.0%> (+3.4%) ⬆️

KZzizzle
KZzizzle approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

@odeimaiz odeimaiz merged commit deffa4b into ITISFoundation:master Jan 21, 2021
@odeimaiz odeimaiz deleted the e2e-fix-Start-template-instead-of-service branch January 21, 2021 13:39
@sanderegg sanderegg mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@KZzizzle KZzizzle KZzizzle approved these changes

@pcrespov pcrespov pcrespov approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@odeimaiz odeimaiz

Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Chronos
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @GitHK @KZzizzle @pcrespov