Skip to content

Feature export/import study (frontend) #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 274 commits into from
Jan 26, 2021
Merged

Feature export/import study (frontend) #2103

merged 274 commits into from
Jan 26, 2021

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 24, 2021 •
edited
Loading

What do these changes do?

Implements the frontend part for Exporting and Importing studies.
It also introduces the concept of background tasks that can be used for requests that can take long. The tasks are added to a stack hanging from the navigation bar, so that they are visible throughout the application. This way we allow users to keep enjoying the application while the background tasks keep running.

  • When Exporting a study, a task is added to the Tasks stack, and as soon as the files are ready the download part starts.
  • When Importing a study, not only the task is added to the Tasks stack, but also a placeholder card is added to the list studies showing the progress of the file being uploaded, then the processing files step and finally it turns into a regular study card. Marvellous.

Bonus

  • /export -> :xport, GET -> POST

Export and import:
import

Related issue/s

Related to ITISFoundation/osparc-issues#325

How to test

Checklist

Andrei Neagu and others added 30 commits December 21, 2020 10:44
removed unused
7069fcc
refactored importers into formatters
92b5d7a
@GitHK
Merge branch 'master' into feature-export-import
d2e59d2
refactored code to use formatters and models
e50edd6
@GitHK
Merge branch 'master' into feature-export-import
048f793
refactored code structure
3a68673
moved LinkAndFile to Pydantic model
6ac2bfa
split storge from relative file path
92dfdc3
added data shuffling to project data and files
2d52303
renamed models to avoid confusion
6f4b94d
refactored from classmethod
b7a1fda
@GitHK
Merge branch 'master' into feature-export-import
22702ea
Merge branch 'feature-export-import' of github.com:GitHK/osparc-simco…
73d0911 
…re-forked into feature-export-import
changed data types to allow for import/export of projects
7a61892
first startable project after export/import
19de0f1
pylint: imports and params cleanup
a0412ce
fixed codeclimate
299adef
trying to bypass codeclimate
9ddce14
fix pylint
69cd39d
exporter
c736b7f
put back temp dir removal
07e6eb5
importing a project also creates its files
2720691 
refactor logging to debug
@odeimaiz
aesthetics
c56a4a0
@odeimaiz
Show TSR text together with the Stars
f13d138
@odeimaiz
e2e: print number of studies received + refactoring
2828ce9
@odeimaiz
minor
2e0592d
@odeimaiz
minor
9301437
@odeimaiz
metadata -> quality
707bc3d
@odeimaiz
rename
1ea112e
@odeimaiz
quality added to project models
be5c184
odeimaiz and others added 2 commits January 25, 2021 18:05
@odeimaiz
minor
72ac112
@odeimaiz
Merge pull request #80 from GitHK/odeimaiz-GitHK-feature-export-import
15054e9 
opsie, raising timeout for downloading files to 1 hour
@odeimaiz odeimaiz changed the title WIP: Feature export/import study (frontend) Feature export/import study (frontend) Jan 25, 2021
@odeimaiz odeimaiz marked this pull request as ready for review January 25, 2021 17:13
KZzizzle
KZzizzle approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coool let's get it in!

sanderegg
sanderegg requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice work!
just one thing to change back the GET to POST as explained here

@GitHK GitHK mentioned this pull request Jan 26, 2021
Closed
ignapas
ignapas approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool stuff

@odeimaiz odeimaiz requested a review from sanderegg January 26, 2021 10:33
sanderegg
sanderegg approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!! thanks for the change @GitHK @odeimaiz

@odeimaiz odeimaiz merged commit feaa2e2 into ITISFoundation:master Jan 26, 2021
@odeimaiz odeimaiz deleted the odeimaiz-GitHK-feature-export-import branch February 24, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignapas ignapas ignapas approved these changes

@KZzizzle KZzizzle KZzizzle approved these changes

@sanderegg sanderegg sanderegg approved these changes

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

@mguidon mguidon Awaiting requested review from mguidon

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Chronos
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @ignapas @GitHK @KZzizzle @sanderegg