-
Notifications
You must be signed in to change notification settings - Fork 28
BugFix: fixes awaitables and broad-exceptions in garbage-collector #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
======================================
Coverage 73.4% 73.4%
======================================
Files 456 456
Lines 17195 17197 +2
Branches 1690 1689 -1
======================================
+ Hits 12633 12637 +4
+ Misses 4112 4111 -1
+ Partials 450 449 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e69fc22
to
0c4f898
Compare
0c4f898
to
f9d2c1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, I see you reduced the scope of error catching in the GC to only database errors.
I have only 2 rename requests
What do these changes do?
Another group of fixes from PR #2079 associated with issues in the garbage collector.
CancelledError
which avoided the gc. Since the gc is a periodic background task it could never be cancelledHow to test
cover this bugfix