Skip to content

bugfix: pipeline without computational service is not created in comp_tasks table #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 25, 2021

Fixes issue where Mattward/Jupyters e2e was failing.
When there are no computational services in a pipeline, the entries shall still be made in comp_tasks table for the dynamic services to run correctly.

What do these changes do?

Related issue/s

How to test

make build-x up-prod

create a pipeline with just dynamic services... retrieve data is working as it should.

Checklist

@sanderegg sanderegg added this to the Chronos milestone Jan 25, 2021
@sanderegg sanderegg self-assigned this Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #2105 (783e70b) into master (8501538) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2105   +/-   ##
======================================
  Coverage    73.7%   73.7%           
======================================
  Files         454     454           
  Lines       16777   16777           
  Branches     1668    1668           
======================================
+ Hits        12371   12377    +6     
+ Misses       3957    3954    -3     
+ Partials      449     446    -3     
Flag Coverage Δ
integrationtests 65.4% <100.0%> (+<0.1%) ⬆️
unittests 67.3% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore_service_director_v2/api/routes/computations.py 89.1% <100.0%> (ø)
...simcore_service_webserver/projects/projects_api.py 85.0% <0.0%> (+0.5%) ⬆️
...ce_webserver/resource_manager/garbage_collector.py 78.5% <0.0%> (+0.9%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 91.0% <0.0%> (+3.3%) ⬆️

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg merged commit 49467d0 into ITISFoundation:master Jan 25, 2021
@sanderegg sanderegg deleted the bugfix/pipeline_with_no_comp_services branch January 25, 2021 15:22
@sanderegg sanderegg mentioned this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants