Skip to content

UI improvements #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jan 28, 2021
Merged

UI improvements #2109

merged 22 commits into from
Jan 28, 2021

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 26, 2021

What do these changes do?

  • Tooltips on zoom buttons
  • Thumbnails take maximum the space they get
  • Sweeper button to WorkbenchToolbar
  • e2e: throw error if service doesn't start after timeout
  • e2e: catch errors in p2e
  • removed fake frontend categories (Postpro, Notebook, Solver, Simulator, Modeling, Data)

Related issue/s

closes ITISFoundation/osparc-issues#396
closes ITISFoundation/osparc-issues#387

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #2109 (5b4395f) into master (5d21604) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2109     +/-   ##
========================================
- Coverage    73.7%   73.7%   -0.1%     
========================================
  Files         454     454             
  Lines       16794   16794             
  Branches     1670    1670             
========================================
- Hits        12387   12386      -1     
  Misses       3961    3961             
- Partials      446     447      +1     
Flag Coverage Δ
integrationtests 65.4% <ø> (-0.1%) ⬇️
unittests 67.3% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...webserver/computation_comp_tasks_listening_task.py 87.6% <0.0%> (-3.4%) ⬇️
...simcore_service_webserver/projects/projects_api.py 84.5% <0.0%> (-0.6%) ⬇️
.../director/src/simcore_service_director/producer.py 61.1% <0.0%> (+0.6%) ⬆️

@odeimaiz odeimaiz self-assigned this Jan 26, 2021
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) UX_improvements UX Feedback during frontend testing process labels Jan 26, 2021
@odeimaiz odeimaiz added this to the Chronos milestone Jan 26, 2021
@odeimaiz odeimaiz changed the title WIP: Improve/fix Zoom and implement Pan WIP: UI improvements Jan 28, 2021
@odeimaiz odeimaiz marked this pull request as ready for review January 28, 2021 13:23
@odeimaiz odeimaiz changed the title WIP: UI improvements UI improvements Jan 28, 2021
Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@odeimaiz odeimaiz merged commit d987529 into ITISFoundation:master Jan 28, 2021
@odeimaiz odeimaiz deleted the feature/zoom-pan branch April 21, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) UX_improvements UX Feedback during frontend testing process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Tags display gets cut in study cards Zoom buttons
3 participants