Is1865/catalog solvers api

[pcrespov]

What do these changes do?

Connects api-server with catalog service

• can list, get released solver (i.e. cataloged computational services )
• this solution is temporary. Next iteration will push to the catalog service most of the logic

Changes in catalog service:

• Fixes OAS: nullable in openapi shall be introduced as an anyOf alternative.

NEW tests/public-api system testing

• deploys simcore stack, ops stack and registry with a sleepr
• registers a user and create API tokens
• run tests using osparc python API client (which is installed from repository)

Related issue/s

• Run solvers from API #1865 Run solvers from API

How to test

Manually

• make sure FAKE_API_SERVER_ENABLED=1 in .env
• build an deploy make build-devel up-devel
• go to http://127.0.0.1:9081, create user and API token under Security-Settings>Create-API-Key
• go to http://127.0.0.1:8006/dev/doc
  • Click upper left "Authorize" button and login using previous key/secret as username/pass
  • Test entries using "Try it out"

Auto

cd tests/public-api
make install-dev
make tests

Checklist

• update client-api to call catalog API
• implement get and list
• Unit tests for the changes exist
• Unit tests of api-server are failing in ALL PR ... probably some unpinned dependency upgraded
• Update OAS and tag client when merged
• Merge client first to master and change requirements link @master-frozen!

[codecov]

Codecov Report

Merging #2112 (44572f9) into master (3e051b5) will decrease coverage by 4.0%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2112      +/-   ##
=========================================
- Coverage    73.5%   69.5%    -4.1%     
=========================================
  Files         456     158     -298     
  Lines       17122    6878   -10244     
  Branches     1685     668    -1017     
=========================================
- Hits        12600    4786    -7814     
+ Misses       4073    1896    -2177     
+ Partials      449     196     -253     

Flag	Coverage Δ
integrationtests	59.9% <ø> (-5.6%)	⬇️
unittests	58.3% <ø> (-8.8%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...erver/src/simcore_service_webserver/rest_models.py	0.0% <0.0%> (-91.2%)	⬇️
...src/simcore_service_webserver/activity/handlers.py	27.1% <0.0%> (-62.9%)	⬇️
...ver/src/simcore_service_webserver/rest_handlers.py	48.1% <0.0%> (-51.9%)	⬇️
...src/simcore_service_webserver/groups_exceptions.py	53.3% <0.0%> (-46.7%)	⬇️
...simcore_service_webserver/activity/module_setup.py	55.5% <0.0%> (-44.5%)	⬇️
.../simcore_service_webserver/security_permissions.py	0.0% <0.0%> (-43.8%)	⬇️
...er/src/simcore_service_webserver/users_handlers.py	53.4% <0.0%> (-41.4%)	⬇️
...re_service_webserver/projects/projects_handlers.py	48.9% <0.0%> (-41.0%)	⬇️
.../server/src/simcore_service_webserver/users_api.py	53.9% <0.0%> (-40.0%)	⬇️
.../src/simcore_service_webserver/diagnostics_core.py	50.8% <0.0%> (-38.6%)	⬇️
... and 318 more

[GitHK]

Some comments/questions on the PR

[sanderegg]

some things already.. might continue later

[sanderegg]

very nice work. and the public-api test you aim to use it also from the e2e?

[sanderegg]

great! looking forward to the additional test suite

[GitHK]

👍 nothing to add here