Skip to content

General fixes to import/export #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Feb 12, 2021
Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 1, 2021

What do these changes do?

  • quality was not saved while importing
  • duplicate study API duplicate study osparc-issues#402
  • archiving module functions interface updated
  • unarchiving will no longer create race conditions

Note: proper locking will come with separate PR, as a lot of systems need to be touched in refactoring the status.

Related issue/s

closes ITISFoundation/osparc-issues#402

How to test

Checklist

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #2120 (b72e52f) into master (e684b94) will increase coverage by 4.5%.
The diff coverage is 90.1%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2120     +/-   ##
========================================
+ Coverage    73.4%   77.9%   +4.5%     
========================================
  Files         456     247    -209     
  Lines       17197    9962   -7235     
  Branches     1689     979    -710     
========================================
- Hits        12632    7767   -4865     
+ Misses       4113    1878   -2235     
+ Partials      452     317    -135     
Flag Coverage Δ
integrationtests 66.0% <90.1%> (+0.5%) ⬆️
unittests 70.6% <25.9%> (+3.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vice_webserver/exporter/formatters/formatter_v1.py 79.5% <ø> (ø)
...er/src/simcore_service_webserver/security_roles.py 100.0% <ø> (ø)
...rc/simcore_service_webserver/exporter/archiving.py 81.1% <86.4%> (-15.4%) ⬇️
...imcore_service_webserver/exporter/export_import.py 95.1% <100.0%> (+6.2%) ⬆️
...ore_service_webserver/exporter/request_handlers.py 83.9% <100.0%> (+3.9%) ⬆️
.../simcore-sdk/src/simcore_sdk/node_data/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...core-sdk/src/simcore_sdk/node_data/data_manager.py 0.0% <0.0%> (-95.3%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-91.2%) ⬇️
...src/simcore_service_sidecar/celery_configurator.py 0.0% <0.0%> (-91.2%) ⬇️
...src/simcore_service_webserver/activity/handlers.py 27.1% <0.0%> (-62.9%) ⬇️
... and 261 more

@pcrespov pcrespov changed the title General fixes to import/export WIP: General fixes to import/export Feb 3, 2021
@GitHK GitHK changed the title WIP: General fixes to import/export General fixes to import/export Feb 11, 2021
@GitHK GitHK marked this pull request as ready for review February 11, 2021 14:51
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss the "Exporting" and "Duplicating" states

@GitHK
Copy link
Contributor Author

GitHK commented Feb 11, 2021

I miss the "Exporting" and "Duplicating" states

Will come with future PR, I wanted to keep them separated for now

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Now we can duplicate and speed-zip/unzip ! :-)

Please consider my comments

@GitHK GitHK requested a review from pcrespov February 12, 2021 10:45
@GitHK GitHK merged commit e92177f into ITISFoundation:master Feb 12, 2021
@GitHK GitHK deleted the fixes-import-export branch February 12, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate study
3 participants