-
Notifications
You must be signed in to change notification settings - Fork 28
General fixes to import/export #2120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2120 +/- ##
========================================
+ Coverage 73.4% 77.9% +4.5%
========================================
Files 456 247 -209
Lines 17197 9962 -7235
Branches 1689 979 -710
========================================
- Hits 12632 7767 -4865
+ Misses 4113 1878 -2235
+ Partials 452 317 -135
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- destination_folder is required for archiving and unarchiving - no more race conditions during parallel unrachive
…-forked into fixes-import-export
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I miss the "Exporting" and "Duplicating" states
Will come with future PR, I wanted to keep them separated for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Now we can duplicate and speed-zip/unzip ! :-)
Please consider my comments
What do these changes do?
Note: proper locking will come with separate PR, as a lot of systems need to be touched in refactoring the status.
Related issue/s
closes ITISFoundation/osparc-issues#402
How to test
Checklist