Skip to content

Bind node states to GUI elements #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 210 commits into from
Feb 24, 2021

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 17, 2021

What do these changes do?

Nodes now have three different state properties and these will be either bound or set as restrictions in the Workbench View, Node View and Guided Mode:

  • Dependencies: Node still waiting for an input coming from the upstream
    • WV: colored the "in" label in the Node box.
    • NV: Show an icon in the inputs on the left
    • GM: Grey out nodes that are waiting for dependencies. When clicking on a greyed out step, ask for running all the previous ones.
  • Running/Interactive: Node's running state:
    • WV: colored NodeStatus text in the Node box
    • NV: Show the running status on the toolbar
    • GM: Running status on breadcrumb
  • Modified: Node is out of date. A combination of a input modified in the node itself && waiting for dependencies
    • WV: colored the "out" label in the Node box. The edge will also show that the current output was modified
    • NV: Show an icon in the outputs on the right
    • GM: Propagate modified downstream

Bonus:

  • Ask for re-run

Workbench View:
WV

Node View:
NV

Guided Mode:
GM

Related issue/s

related to ITISFoundation/osparc-issues#327
closes #2102
related to #1950
closes ITISFoundation/osparc-issues#371

How to test

Checklist

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colors are definitively improving the UX! Very nice! 👍

@ignapas
Copy link
Contributor

ignapas commented Feb 24, 2021

review time!

@odeimaiz
Copy link
Member Author

hmm: red, blue, orange, green
image
Otherwise looking great

Red, orange and blue are fixed colors... the green one appeared there by pure chance. We could constrain the random color generator to avoid the green spectrum....

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@odeimaiz odeimaiz merged commit 4a5956a into ITISFoundation:master Feb 24, 2021
@odeimaiz odeimaiz deleted the sanderegg-retrieve_more_states branch April 21, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need to modify frontend to force restart a pipeline Run next node by default when in Guided Mode
6 participants