-
Notifications
You must be signed in to change notification settings - Fork 28
Bind node states to GUI elements #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
odeimaiz
merged 210 commits into
ITISFoundation:master
from
odeimaiz:sanderegg-retrieve_more_states
Feb 24, 2021
Merged
Bind node states to GUI elements #2153
odeimaiz
merged 210 commits into
ITISFoundation:master
from
odeimaiz:sanderegg-retrieve_more_states
Feb 24, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colors are definitively improving the UX! Very nice! 👍
- This closes Move logger into comp service node-view #1950? Did you really moved the logs below the settings in a computational service? can you add a screenshot?
- You forgot yellow? ;-)
review time! |
…sparc-simcore into sanderegg-retrieve_more_states
sanderegg
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Nodes now have three different state properties and these will be either bound or set as restrictions in the Workbench View, Node View and Guided Mode:
Bonus:
Workbench View:

Node View:

Guided Mode:

Related issue/s
related to ITISFoundation/osparc-issues#327
closes #2102
related to #1950
closes ITISFoundation/osparc-issues#371
How to test
Checklist