Skip to content

wait for notebook to complete #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 8, 2021

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 3, 2021

What do these changes do?

wait until jupyter notebook completed execution

Bonus:

  • add some healthchecks for postgres/redis

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #2190 (f31e657) into master (50240e5) will increase coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2190     +/-   ##
========================================
+ Coverage    73.1%   73.5%   +0.4%     
========================================
  Files         465     283    -182     
  Lines       17902   12886   -5016     
  Branches     1763    1353    -410     
========================================
- Hits        13090    9481   -3609     
+ Misses       4354    3019   -1335     
+ Partials      458     386     -72     
Flag Coverage Δ
integrationtests 65.3% <ø> (-0.1%) ⬇️
unittests 64.4% <ø> (-2.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore-sdk/src/simcore_sdk/node_data/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...core-sdk/src/simcore_sdk/node_data/data_manager.py 0.0% <0.0%> (-91.7%) ⬇️
...er/src/simcore_service_webserver/studies_access.py 24.2% <0.0%> (-64.5%) ⬇️
...er/src/simcore_service_webserver/login/handlers.py 27.9% <0.0%> (-59.9%) ⬇️
...mcore_service_webserver/login/api_keys_handlers.py 36.7% <0.0%> (-55.9%) ⬇️
...eb/server/src/simcore_service_webserver/statics.py 39.3% <0.0%> (-49.2%) ⬇️
...rc/simcore_service_webserver/login/confirmation.py 33.3% <0.0%> (-47.3%) ⬇️
...core_service_webserver/studies_dispatcher/_core.py 45.4% <0.0%> (-44.0%) ⬇️
...rc/simcore_service_webserver/login/registration.py 30.1% <0.0%> (-43.4%) ⬇️
...erver/src/simcore_service_webserver/application.py 51.3% <0.0%> (-41.7%) ⬇️
... and 228 more

@@ -272,6 +272,10 @@ services:
- default
- interactive_services_subnet
- computational_services_subnet
healthcheck:
test: ["CMD", "pg_isready", "-U", "${POSTGRES_USER}"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition!

@pcrespov pcrespov added the e2e Bugs found by or related to the end-2-end testing label Mar 4, 2021
@sanderegg sanderegg force-pushed the e2e_wait_for_notebook branch from bfa7efe to 18b8d91 Compare March 5, 2021 07:43
@sanderegg sanderegg requested a review from odeimaiz March 5, 2021 08:42
@sanderegg sanderegg force-pushed the e2e_wait_for_notebook branch 2 times, most recently from e881717 to 449e1e0 Compare March 8, 2021 08:10
@sanderegg sanderegg force-pushed the e2e_wait_for_notebook branch from 449e1e0 to 4eee069 Compare March 8, 2021 08:11
@sanderegg sanderegg merged commit d8e7bcc into ITISFoundation:master Mar 8, 2021
@sanderegg sanderegg deleted the e2e_wait_for_notebook branch March 8, 2021 08:35
@sanderegg sanderegg added this to the The Red Panda milestone Mar 24, 2021
@sanderegg sanderegg mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants