-
Notifications
You must be signed in to change notification settings - Fork 29
wait for notebook to complete #2190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sanderegg
merged 11 commits into
ITISFoundation:master
from
sanderegg:e2e_wait_for_notebook
Mar 8, 2021
Merged
wait for notebook to complete #2190
sanderegg
merged 11 commits into
ITISFoundation:master
from
sanderegg:e2e_wait_for_notebook
Mar 8, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
========================================
+ Coverage 73.1% 73.5% +0.4%
========================================
Files 465 283 -182
Lines 17902 12886 -5016
Branches 1763 1353 -410
========================================
- Hits 13090 9481 -3609
+ Misses 4354 3019 -1335
+ Partials 458 386 -72
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e392293
to
f8ee557
Compare
pcrespov
approved these changes
Mar 4, 2021
@@ -272,6 +272,10 @@ services: | |||
- default | |||
- interactive_services_subnet | |||
- computational_services_subnet | |||
healthcheck: | |||
test: ["CMD", "pg_isready", "-U", "${POSTGRES_USER}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition!
bfa7efe
to
18b8d91
Compare
e881717
to
449e1e0
Compare
the confirmation dialog does not come up in the notebook
449e1e0
to
4eee069
Compare
odeimaiz
approved these changes
Mar 8, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
wait until jupyter notebook completed execution
Bonus:
Related issue/s
How to test
Checklist