-
Notifications
You must be signed in to change notification settings - Fork 28
Extending data_manager #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending data_manager #2196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2196 +/- ##
========================================
+ Coverage 72.6% 73.1% +0.4%
========================================
Files 465 465
Lines 17886 17899 +13
Branches 1763 1763
========================================
+ Hits 12990 13085 +95
+ Misses 4435 4355 -80
+ Partials 461 459 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -297,3 +297,25 @@ async def upload_file( | |||
return store_id, e_tag | |||
|
|||
raise exceptions.S3InvalidPathError(s3_object) | |||
|
|||
|
|||
async def is_metadata_for_entry(store_id: str, s3_object: str) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: i wonder if this coroutine can be cancelled because you are capturing with a broad-except. See this example:
async def foo():
...
await is_metadata_for_entry(..)
...
# somewhere else, a code calls to cancel task associated to foo
task_foo.cancel()
await task_foo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just check my suggestions. otherwise this looks perfect.
Co-authored-by: Sylvain <[email protected]>
…-forked into extending-nodeports
What do these changes do?
Adds
is_file_present_in_storage
call to thedata_manager
. This will help with saving and restoring states for dynamic service.Related issue/s
helps solving ITISFoundation/osparc-issues#429
How to test
Checklist