Skip to content

E2e wait for notebook2 #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • run all cells with menu command
  • fix healthcheck on postgres

Related issue/s

How to test

Checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Mar 8, 2021
@sanderegg sanderegg added this to the The Unknown Sprint milestone Mar 8, 2021
@sanderegg sanderegg requested a review from odeimaiz March 8, 2021 09:21
@sanderegg sanderegg self-assigned this Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #2198 (95dec3a) into master (d8e7bcc) will decrease coverage by 13.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2198      +/-   ##
=========================================
- Coverage    73.1%   59.3%   -13.8%     
=========================================
  Files         465     123     -342     
  Lines       17902    3514   -14388     
  Branches     1763     341    -1422     
=========================================
- Hits        13089    2086   -11003     
+ Misses       4355    1381    -2974     
+ Partials      458      47     -411     
Flag Coverage Δ
integrationtests ?
unittests 59.3% <ø> (-7.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/simcore-sdk/src/simcore_sdk/models/base.py 0.0% <0.0%> (-100.0%) ⬇️
...ges/simcore-sdk/src/simcore_sdk/models/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...core-sdk/src/simcore_sdk/models/pipeline_models.py 0.0% <0.0%> (-64.6%) ⬇️
...re-sdk/src/simcore_sdk/node_ports/serialization.py 24.6% <0.0%> (-57.0%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/nodeports.py 27.7% <0.0%> (-50.1%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/dbmanager.py 41.2% <0.0%> (-44.5%) ⬇️
...core-sdk/src/simcore_sdk/node_ports/filemanager.py 47.7% <0.0%> (-35.1%) ⬇️
...es/simcore-sdk/src/simcore_sdk/node_ports/_item.py 65.5% <0.0%> (-28.7%) ⬇️
...sdk/src/simcore_sdk/node_ports/_data_items_list.py 55.2% <0.0%> (-10.6%) ⬇️
...k/src/simcore_sdk/node_ports/_schema_items_list.py 91.3% <0.0%> (-8.7%) ⬇️
... and 346 more

@sanderegg sanderegg merged commit f3d9592 into ITISFoundation:master Mar 8, 2021
@sanderegg sanderegg deleted the e2e_wait_for_notebook2 branch March 8, 2021 09:24
@sanderegg sanderegg mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants