Skip to content

if metadata file did not exist it would crash #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 8, 2021

What do these changes do?

When requesting metadata for a file which dose not exist storage would be crashing. This is now avoided.

Note: without this fix deployed to staging and production the fixed jupyter-labs will not work.

Related issue/s

addresses part of ITISFoundation/osparc-issues#429

How to test

Checklist

@GitHK GitHK added the bug buggy, it does not work as expected label Mar 8, 2021
@GitHK GitHK self-assigned this Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #2201 (21bab22) into master (4772247) will increase coverage by 3.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2201     +/-   ##
========================================
+ Coverage    73.0%   76.9%   +3.9%     
========================================
  Files         465     249    -216     
  Lines       17905   10381   -7524     
  Branches     1763    1026    -737     
========================================
- Hits        13082    7993   -5089     
+ Misses       4362    2064   -2298     
+ Partials      461     324    -137     
Flag Coverage Δ
integrationtests 65.3% <ø> (+<0.1%) ⬆️
unittests 69.5% <ø> (+3.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore-sdk/src/simcore_sdk/node_data/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-91.2%) ⬇️
...src/simcore_service_sidecar/celery_configurator.py 0.0% <0.0%> (-91.2%) ⬇️
...core-sdk/src/simcore_sdk/node_data/data_manager.py 0.0% <0.0%> (-89.8%) ⬇️
...src/simcore_service_webserver/activity/handlers.py 27.1% <0.0%> (-62.9%) ⬇️
...ver/src/simcore_service_webserver/rest_handlers.py 48.1% <0.0%> (-51.9%) ⬇️
...simcore_service_webserver/activity/module_setup.py 55.5% <0.0%> (-44.5%) ⬇️
.../simcore_service_webserver/security_permissions.py 0.0% <0.0%> (-43.8%) ⬇️
.../src/simcore_service_webserver/diagnostics_core.py 50.8% <0.0%> (-39.0%) ⬇️
...rc/simcore_service_webserver/catalog_api_models.py 55.5% <0.0%> (-33.4%) ⬇️
... and 263 more

Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beauty in simplicity

@GitHK GitHK merged commit 790bac2 into ITISFoundation:master Mar 9, 2021
@GitHK GitHK added this to the The Red Panda milestone Mar 9, 2021
@sanderegg sanderegg added the a:storage issue related to storage service label Mar 24, 2021
@sanderegg sanderegg mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants