Skip to content

Webserver: handle 500s from director-v2 gracefully #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

What do these changes do?

when some network glitch happens when webserver talks with director-v2 to get the pipeline status a 500 could come back to the frontend. Now this should be catched and an UNKNOWN status is returned.

partially fixes #2155

Related issue/s

How to test

Checklist

@sanderegg sanderegg added this to the The Red Panda milestone Mar 10, 2021
@sanderegg sanderegg requested review from GitHK, odeimaiz and mguidon March 10, 2021 14:37
@sanderegg sanderegg self-assigned this Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #2202 (683656e) into master (cb75149) will increase coverage by 0.0%.
The diff coverage is 66.6%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2202   +/-   ##
======================================
  Coverage    73.0%   73.0%           
======================================
  Files         465     465           
  Lines       17907   17907           
  Branches     1764    1764           
======================================
+ Hits        13086   13088    +2     
+ Misses       4361    4360    -1     
+ Partials      460     459    -1     
Flag Coverage Δ
integrationtests 65.3% <66.6%> (+<0.1%) ⬆️
unittests 66.4% <66.6%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/director_v2.py 88.1% <66.6%> (+0.8%) ⬆️
...simcore_service_webserver/projects/projects_api.py 86.8% <0.0%> (+0.4%) ⬆️

@sanderegg sanderegg force-pushed the fix_director_failure_handling branch from 53312fa to 683656e Compare March 10, 2021 14:55
@sanderegg sanderegg merged commit 01e6266 into ITISFoundation:master Mar 10, 2021
@sanderegg sanderegg deleted the fix_director_failure_handling branch March 10, 2021 16:38
@sanderegg sanderegg added the a:webserver issue related to the webserver service label Mar 24, 2021
@sanderegg sanderegg mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

review error handling in add_project_states_for_user in webserver
2 participants