-
Notifications
You must be signed in to change notification settings - Fork 28
♻️✨adding nodeports support to dynamic-sidecar #2509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2509 +/- ##
========================================
- Coverage 77.0% 77.0% -0.1%
========================================
Files 625 630 +5
Lines 24094 24741 +647
Branches 2362 2430 +68
========================================
+ Hits 18567 19057 +490
- Misses 4890 5040 +150
- Partials 637 644 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Aug 30, 2021
8 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a:director-v2
issue related with the director-v2 service
t:enhancement
Improvement or request on an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Services booted via dynamic-sidecar will have the ports pulled and pushed for themselves. Also the
state
of the service is being handled by the dynamic-sidecar.Service state integration
docker-compose up
and creating all the images, the dynamic-sidecar will pull the state of the service.docker-compose down
the state of the service is saved.state_paths
key here.state_paths
will be mounted as a separate volume.Nodeports integration
osparc.io/x/UUID/retrieve
endpoint. Instead a call toosparc.io/projects/PROJECT_ID/nodes/NODE_ID/retrieve
will be made. The webserver will forward the request to the director-v2 which in turn will call into they dynamic-sidecar's API. The event chain will pull data frominput ports
.docker-compose down
,output ports
are pushed.outputs directory
. When changes occur to this directoryoutput ports
are pushed.Done/todos:
gid=8004
anduid=8004
like heresimcore-sdk
'sdata_manager.pull
now supportssave_to
option to save to a different folderretrieve
andstatus
from director-v2; these sometimes failed because the service was not immediately responsible.Related issue/s
How to test
Boot stack locally in development or production mode.
Use the following images. Note: you might need to manually assign permissions from the database:
simcore/services/dynamic/dy-static-file-server-dynamic-sidecar:2.0.0
simcore/services/dynamic/dy-static-file-server-dynamic-sidecar-compose-spec:2.0.0
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)