-
Notifications
You must be signed in to change notification settings - Fork 28
✨ Enhancement/allow node port to get set value #2605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enhancement/allow node port to get set value #2605
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2605 +/- ##
========================================
- Coverage 77.2% 75.0% -2.2%
========================================
Files 621 621
Lines 23971 24043 +72
Branches 2362 2367 +5
========================================
- Hits 18507 18052 -455
- Misses 4826 5389 +563
+ Partials 638 602 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find some questions below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this PR introduces:
simcore-sdk
'sport.get_value
resolves port and file links into valid downloadable links andport.get
resolves to a value in memory or in a file-path. Some thoughts:- Naming of all these functions (i.e.
get_value
orget
) are too generic and cannot what it does without analyzing the code - Same with Item and ContreteItem. Why a path is a concrete item? It is rather a link to the concrete. I find there are too many indirections (links to links to links) and are not clearly organized.
- Naming of all these functions (i.e.
- director service waits for registry to be responsive upon startup.
- consider
on_startup
for setup
- consider
What do these changes do?
to bring the dask sidecar in:
some additional small fixes/refactors
Related issue/s
How to test
make build cd simcore_sdk make install-dev make tests
Checklist