Skip to content

✨ Enhancement/allow node port to get set value #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 26, 2021

What do these changes do?

to bring the dask sidecar in:

  • the node ports package now allow to get/set the link to S3-backed file without actually directly downloading/uploading the file through the node_ports, but in a delayed manner (the dask-sidecar has no access to the database, but still need a pre-signed link to download/upload)

some additional small fixes/refactors

Related issue/s

How to test

make build
cd simcore_sdk
make install-dev
make tests

Checklist

@sanderegg sanderegg added a:webserver issue related to the webserver service a:sidecar issue related with the sidecar worker service labels Oct 26, 2021
@sanderegg sanderegg added this to the Anti-PER milestone Oct 26, 2021
@sanderegg sanderegg self-assigned this Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #2605 (75d8215) into master (50b5eb2) will decrease coverage by 2.1%.
The diff coverage is 53.9%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2605     +/-   ##
========================================
- Coverage    77.2%   75.0%   -2.2%     
========================================
  Files         621     621             
  Lines       23971   24043     +72     
  Branches     2362    2367      +5     
========================================
- Hits        18507   18052    -455     
- Misses       4826    5389    +563     
+ Partials      638     602     -36     
Flag Coverage Δ
integrationtests 77.7% <42.0%> (+11.9%) ⬆️
unittests 71.7% <52.2%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels-library/src/models_library/settings/rabbit.py 0.0% <0.0%> (ø)
.../service-library/src/servicelib/archiving_utils.py 57.4% <0.0%> (ø)
.../simcore-sdk/src/simcore_sdk/node_ports_v2/port.py 76.1% <28.0%> (-20.7%) ⬇️
...-sdk/src/simcore_sdk/node_ports_v2/nodeports_v2.py 94.3% <44.4%> (-5.7%) ⬇️
...re-sdk/src/simcore_sdk/node_ports_v2/port_utils.py 75.3% <48.4%> (-19.6%) ⬇️
...tor/src/simcore_service_director/registry_proxy.py 66.9% <82.7%> (+1.8%) ⬆️
...ings-library/src/settings_library/logging_utils.py 87.5% <100.0%> (+0.8%) ⬆️
...simcore-sdk/src/simcore_sdk/node_ports_v2/links.py 100.0% <100.0%> (ø)
...imcore_service_director/cache_request_decorator.py 100.0% <100.0%> (ø)
...ices/director/src/simcore_service_director/main.py 89.4% <100.0%> (+1.2%) ⬆️
... and 33 more

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find some questions below

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this PR introduces:

  • simcore-sdk's port.get_value resolves port and file links into valid downloadable links and port.get resolves to a value in memory or in a file-path. Some thoughts:
    • Naming of all these functions (i.e. get_value or get) are too generic and cannot what it does without analyzing the code
    • Same with Item and ContreteItem. Why a path is a concrete item? It is rather a link to the concrete. I find there are too many indirections (links to links to links) and are not clearly organized.
  • director service waits for registry to be responsive upon startup.
    • consider on_startup for setup

@sanderegg sanderegg merged commit b014be7 into ITISFoundation:master Oct 26, 2021
@sanderegg sanderegg deleted the enhancement/allow_node_port_to_get_set_value branch October 26, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:sidecar issue related with the sidecar worker service a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants