Skip to content

Is200/auth business logic #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 83 commits into from
Oct 30, 2018

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Oct 22, 2018

What do these changes do?

Business logic for:

  • user session
  • login/logout/registration/confirmation/rest
  • new modules in servicelib for aipg, aiohttp ext ...
  • added deploytools: merges docker files, creates

Related issue number

Connects to #200

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Check it runs in swarm
  • If you design a new module, add your user to .github/CODEOWNERS

Pedro Crespo added 30 commits July 6, 2018 14:34
 - users, confirmations, tokens and roles
 - adapted security autherication policy
 -
@pcrespov pcrespov changed the title WIP: Is200/auth business logic Is200/auth business logic Oct 29, 2018
@pcrespov pcrespov requested a review from odeimaiz October 29, 2018 15:03
pcrespov and others added 3 commits October 29, 2018 21:11
 - finds services/docker-compose* files
 - merges docker-compose files
 - resolves services/docker-compose files and produces a  docker-compose for deployment
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pair review

@pcrespov pcrespov merged commit 5ef5591 into ITISFoundation:master Oct 30, 2018
@ghost ghost removed the review label Oct 30, 2018
@pcrespov pcrespov deleted the is200/auth-business-logic branch October 31, 2018 13:48
oetiker pushed a commit to oetiker/osparc-simcore that referenced this pull request Nov 1, 2018
## What do these changes do?
Business logic for:
- user session
- login/logout/registration/confirmation/rest
- new modules in servicelib for aipg, aiohttp ext ...
- added deploytools: merges docker files, creates

## Related issue number
Resolves ITISFoundation#200 


## Important commits

* Modified app's config to accomodate options for smtp server
Added new keys for db's pool

* Login:
 - created setup
 - added test_login, test_registration
 - shorten config

* Cleanup testing. Disabled old tests and modifying testing configuration

* tests/login/test_login passes
 - login setup connected on app startup
 - added smtp to config file
 - asyncpg needs enum names (not values)

* servicelib: created response_utils

* test_registration passes
 - activated renderer for email
 - fixes openapi formatters (openapicore does not support uuid formatter marshaling)
 - template resources

* test_logout
 - refactoring test utils
 - moved all routes under login

* Replacing cfg.STORAGE singleton by application storage

* test_login runs
added change email
other fixes in utils

* servicelib new utils

* Fixes null parameters in configuration
 - adds testing for configs

* Added email setup and hides renderer setup

* Started deploy tools (prototype)
 - finds services/docker-compose* files
 - merges docker-compose files
 - resolves services/docker-compose files and produces a  docker-compose for deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants