-
Notifications
You must be signed in to change notification settings - Fork 28
Is200/auth business logic #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pcrespov
merged 83 commits into
ITISFoundation:master
from
pcrespov:is200/auth-business-logic
Oct 30, 2018
Merged
Is200/auth business logic #275
pcrespov
merged 83 commits into
ITISFoundation:master
from
pcrespov:is200/auth-business-logic
Oct 30, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- users, confirmations, tokens and roles - adapted security autherication policy -
Fixes missing environs in webserver
- public_url variable accepts now a single or a list of urls - modified servers schemas to include basePath variable
…c-simcore into is200/auth-business-logic
- adds testing for configs
odeimaiz
approved these changes
Oct 29, 2018
- finds services/docker-compose* files - merges docker-compose files - resolves services/docker-compose files and produces a docker-compose for deployment
mguidon
approved these changes
Oct 30, 2018
sanderegg
approved these changes
Oct 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pair review
oetiker
pushed a commit
to oetiker/osparc-simcore
that referenced
this pull request
Nov 1, 2018
## What do these changes do? Business logic for: - user session - login/logout/registration/confirmation/rest - new modules in servicelib for aipg, aiohttp ext ... - added deploytools: merges docker files, creates ## Related issue number Resolves ITISFoundation#200 ## Important commits * Modified app's config to accomodate options for smtp server Added new keys for db's pool * Login: - created setup - added test_login, test_registration - shorten config * Cleanup testing. Disabled old tests and modifying testing configuration * tests/login/test_login passes - login setup connected on app startup - added smtp to config file - asyncpg needs enum names (not values) * servicelib: created response_utils * test_registration passes - activated renderer for email - fixes openapi formatters (openapicore does not support uuid formatter marshaling) - template resources * test_logout - refactoring test utils - moved all routes under login * Replacing cfg.STORAGE singleton by application storage * test_login runs added change email other fixes in utils * servicelib new utils * Fixes null parameters in configuration - adds testing for configs * Added email setup and hides renderer setup * Started deploy tools (prototype) - finds services/docker-compose* files - merges docker-compose files - resolves services/docker-compose files and produces a docker-compose for deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Business logic for:
Related issue number
Connects to #200
Checklist