Skip to content

Inputs mapper #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 243 commits into from
Nov 6, 2018
Merged

Inputs mapper #313

merged 243 commits into from
Nov 6, 2018

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 6, 2018 •
edited
Loading

Features:

  • Default/inner inputs concept in (specs need to be adapted)
  • NodePorts belong to NodeModel (avoid recreating them):
    • Ports listed as Labels
    • Ports listed as Trees
  • Inputs Mapper:
    • Allows user to drag & drop items from inputs (inner default inputs or connected node's outputs)
  • TreeItemRenamer class created (InputsMapper uses it)
  • Fake data updated
    • Services:
      • Neuroman
      • StimulationSelectivity
    • Default inputs for (getItemList):
      • Neuroman
      • Material Settings
      • Boundary Conditions
      • Stimulation Selectivity
    • Output list for (getItemList):
      • Modeler
      • MaterialDB
    • Output list data for (getItem):
      • MaterialDB
  • Aesthetics

Bonus:

  • Modeler:
    • loadModel function created to make it easier to use it from outside
    • Clean-up

image

connect #237

oetiker and others added 30 commits June 13, 2018 09:31
@oetiker
initial
9f8ffd4
@oetiker
first complete schema
bc72477
@oetiker
renamed
05a998c
@oetiker
renamed
013f76a
Initial import of comp. services
1c9800f
Adapt sidecar to dockerfile/compose layout
7e2a2e3
fix requirements
ca2a7ad
@oetiker
Merge branch 'master' into json-schema
52bb450
@oetiker
added key property
5fab282
Add server parts needed for comp. backend
b8f4bb7
@oetiker
added initial Avj wrapper
ca84ccf
rename source --> src
76ab87f
@oetiker
added a little validation test to the main app ...
e84ff9b 
look at the console output when loading it :)
fix publish/subscribe initialization and add up to date mockup data
ba51898
change default indentation for python in vscode-tmplate
80d8b4a
change build context for services such that we can copy files from th…
f3ec478 
…e top level directory
minor cleanup
2edb5fb
change build context for server
2043c59
rename debug to devel
a76d220
Adds code coverage output
8034118
Add local minio for devel and template with credentials
8c46412
update readme
c6fee87
WIP: improving first web/client qx docker. Minor cleanup in compose f…
01b8569 
…iles
@oetiker
fix JS syntax
e9131db
Merge branch 'master' into comp_backend
e4facd8
Improved server/client qx compiler container. - non-root user - dev/p…
2bc95bb 
…rod targets
Renamed web/client dockerfile. Emphasizes that it is only to build th…
8aaa103 
…e client's code
Adds log messages while installing qx contribs
703ad74
Renamed client dockerfile since it is multitarget
92c0d73
Renamed webserver dockerfile since it targets ci
e836528
@ghost ghost assigned odeimaiz Nov 6, 2018
@ghost ghost added the review label Nov 6, 2018
pcrespov
pcrespov reviewed Nov 6, 2018
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On UI features, it would be nice to have a screenshot or animated gift of it attached to the PR. It is a way as well to document it.

@odeimaiz
Copy link
Member Author

odeimaiz commented Nov 6, 2018

@pcrespov Good point!

odeimaiz added 2 commits November 6, 2018 16:07
Revert "Merge branch 'osx-swarm-support' of git://github.com/oetiker/…
f51f615 
…osparc-simcore into feature/materialDBOuputsList"

This reverts commit b861135, reversing
changes made to e460e75.
typo
b10e180
@odeimaiz odeimaiz merged commit 1a3ed38 into ITISFoundation:master Nov 6, 2018
@ghost ghost removed the review label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oetiker oetiker oetiker approved these changes

@pcrespov pcrespov pcrespov approved these changes

@mguidon mguidon Awaiting requested review from mguidon

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @oetiker @pcrespov @sanderegg @mguidon