Is207/reverse proxy director (jupyter) #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 28, 2018 20:12
service url considers when the app is in swarm or not
…parc-simcore into is207/reverse-proxy-director
ghost
assigned …ugging upon attach
pcrespov
changed the title
odeimaiz
approved these changes
Nov 29, 2018
pcrespov
added a commit
that referenced
this pull request
Nov 30, 2018
Some missing parts in PR #371 that i did not push to origin. Includes -updates front-end path to dynamic services - fixes in jupyter notebook * webserver.director subsystem: - added a function to retrieve a client provided the application - added notes on a bug * Modifies director API specs. Implementation expected in #363 * cleanup and naming services * running_services get now returns also the service and its key/version * modified tests according to requirements * modified handlers to work according to requirements * updated server information * automatically create the resolved oas file * updated generator version * updated director sdk * updated director openapi * updated version check * fixed regex error in client code * updated sample * revert change * formatted director.producer to ready easier * Implemented ServiceResolutionPolicy with director in application_proxy Activated setup_app_proxy in appliction * Minor * Cleanup dev requirements * Cleanup director tests while reviewing them * Fixes duplicated storage in docker-compose * Minor cleanup and adds apihub dependency to storage * Modified director APi specs * default is empty basepath * generated client for new api with basepath * updated director api server side * Minor cleanup changed APP_SCHEMA by app_schema removed comments so we can pass to xargs in command line * update test for director * updated tests * update to the api * fixed not getting service correctly * added apihub * start notebook with a base path * version bump * added SIMCORE_NODE_BASEPATH * fixed copy of custom.js to set notebook in single-tab mode * fixed alternative basepath * adding missing veriable and baseurl env * refactoring adding base url using async * added config file moved s4l stuff in s4l_utils * Prepared integration-test for reverse proxy - recreates docker-compose and config using existing files and environs - tests fail * websocket also on alternative basepath * duplicate key * pylint * fix failing test * version bump * empty basepath default * handle error * fix catch * fix default env * final fix * Cleanup: - removed pdb breakpoint - added disabling login option for testing - cleanup tests * Fixed webserver.director handlers * Using aiohttp client session instead of sdk * Added makefile to build swarm and tooling * webserver.director found director api endpoint upon setup * application-proxy: - removed reference to director_sdk (using now aiohttp client) - fixed urls * Fixes responses from director * Fixes on jupyter handlers * application_proxy: service url considers when the app is in swarm or not * tests pass using a sleep to wait the service to start * Disableds proxy if director is disabled * Adds stdin_open and tty options in docker-compose.devel to enable debugging upon attach * Fixes oas_repo config for docker-dev. repo root does not exists inside the container! * Front-end now requests interactive services via the reverse proxy * Fixes reverse_proxy jupyter handler * Fixes webserver.projects handler to retrieve template projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
connected to #207
closes #207
Checklist