Skip to content

director transmits its own extra hosts to spawned services *demo #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2018
Merged

director transmits its own extra hosts to spawned services *demo #379

merged 4 commits into from
Nov 29, 2018

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 28, 2018 •
edited
Loading

if there are extra hosts defined for the director it will pass them to the services

What do these changes do?

  • reads in the system extra hosts
  • passes the system extra hosts to the spawned services

Related issue number

connects #305

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@sanderegg
added additional configuration variable for director EXTRA_HOSTS_SUFFIX
e54c084 
if there are extra hosts defined for the director it will pass them to the services
@sanderegg sanderegg added this to the Sagittaron milestone Nov 28, 2018
@sanderegg sanderegg self-assigned this Nov 28, 2018
@ghost ghost added the review label Nov 28, 2018
mguidon
mguidon approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ghost ghost assigned pcrespov Nov 29, 2018
pcrespov
pcrespov reviewed Nov 29, 2018
View reviewed changes
@odeimaiz odeimaiz merged commit 107f558 into ITISFoundation:master Nov 29, 2018
@ghost ghost removed the review label Nov 29, 2018
@sanderegg sanderegg deleted the pass_extra_hosts_services branch December 6, 2018 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@mguidon mguidon mguidon approved these changes

@oetiker oetiker Awaiting requested review from oetiker

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

Assignees

@pcrespov pcrespov

@sanderegg sanderegg

Labels
None yet
Projects
None yet
Milestone
Sagittaron
Development

Successfully merging this pull request may close these issues.
4 participants
@sanderegg @pcrespov @mguidon @odeimaiz