Skip to content

don't wait for the dependencies. the laptops don't like it #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2018
Merged

don't wait for the dependencies. the laptops don't like it #389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47fb6db
demodec: don't wait for the dependencies. the laptops don't like it
sanderegg Nov 30, 2018
2ad647b
Merge branch 'master' into director_does_not_wait_for_dependencies_to…
pcrespov Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions services/director/src/simcore_service_director/producer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ def __set_service_name(docker_service_runtime_parameters: Dict,


def _get_docker_image_port_mapping(service_id: str) -> Tuple[str, str]:
log.debug("getting port published by service: %s", service_id)
# TODO: It could be possible that the endpoint is also accessible using high/level client in service.attrs
# pylint: disable=C0103
low_level_client = docker.APIClient()
Expand Down Expand Up @@ -318,25 +319,27 @@ async def __wait_until_service_running_or_failed(service_id: str,
node_uuid: str):
# pylint: disable=C0103
log.debug("Waiting for service %s to start", service_id)
client = docker.APIClient()
client = docker.from_env()

# some times one has to wait until the task info is filled
while True:
task_infos_json = client.tasks(filters={'service': service_id})
service = client.services.get(service_id)
task_infos_json = service.tasks()
# log.debug("task infos: %s", task_infos_json)
if task_infos_json:
# check the status
status_json = task_infos_json[0]["Status"]
task_state = status_json["State"]

log.debug("%s %s", service_id, task_state)
# log.debug("%s %s", service_id, task_state)
if task_state == "running":
break
elif task_state in ("failed", "rejected"):
log.error("Error while waiting for service")
raise exceptions.ServiceStartTimeoutError(
service_name, node_uuid)
# would allow dealing with other events instead of wasting time here
await asyncio.sleep(0.005) # 5ms
# allows dealing with other events instead of wasting time here
await asyncio.sleep(1) # 1s
log.debug("Waited for service %s to start", service_id)


Expand Down Expand Up @@ -438,7 +441,8 @@ async def _start_docker_service(client: docker.client,
log.debug("Starting docker service %s using parameters %s", docker_image_full_path, docker_service_runtime_parameters)
service = client.services.create(docker_image_full_path, **docker_service_runtime_parameters)
log.debug("Service started now waiting for it to run")
await __wait_until_service_running_or_failed(service.id, docker_image_full_path, node_uuid)
if main_service:
await __wait_until_service_running_or_failed(service.id, docker_image_full_path, node_uuid)
# the docker swarm opened some random port to access the service
published_port, target_port = _get_docker_image_port_mapping(service.id)
log.debug("Service successfully started on %s:%s", service_entrypoint, published_port)
Expand Down