♻️ Api server: improve job creation speed #4053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
approved these changes
Apr 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #4053 +/- ##
=========================================
- Coverage 85.0% 66.6% -18.4%
=========================================
Files 799 397 -402
Lines 37152 20573 -16579
Branches 950 174 -776
=========================================
- Hits 31591 13721 -17870
- Misses 5342 6803 +1461
+ Partials 219 49 -170
Flags with carried forward coverage won't be shown. Click here to find out more. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs.py
Show resolved
Hide resolved
GitHK
approved these changes
Apr 3, 2023
services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs.py
Show resolved
Hide resolved
sanderegg
force-pushed
the
api-server/improve_job_creation_speed
branch
from
380aa86 to
bd93de7
Compare
|
Code Climate has analyzed commit bd93de7 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Apr 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Increase job creation speed by 30%, removing unnecessary call to director-v2
Related issue/s
How to test