Skip to content

♻️ refactor of project comments #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Jun 21, 2023

What do these changes do?

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 changed the title refactor of project comments ♻️ refactor of project comments Jun 21, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 21, 2023 09:56
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 21, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Watermelon milestone Jun 21, 2023
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Jun 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jun 21, 2023

Code Climate has analyzed commit cc5d2cd and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #4393 (cc5d2cd) into master (384e9f1) will decrease coverage by 0.8%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4393      +/-   ##
=========================================
- Coverage    86.0%   85.2%    -0.8%     
=========================================
  Files         986     366     -620     
  Lines       42370   19105   -23265     
  Branches     1006       0    -1006     
=========================================
- Hits        36459   16294   -20165     
+ Misses       5680    2811    -2869     
+ Partials      231       0     -231     
Flag Coverage Δ
integrationtests 67.2% <40.8%> (+0.9%) ⬆️
unittests 86.5% <100.0%> (+2.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...imcore_service_webserver/projects/_comments_api.py 100.0% <ø> (ø)
...simcore_service_webserver/projects/_comments_db.py 100.0% <100.0%> (ø)
...e_service_webserver/projects/_comments_handlers.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/projects/db.py 96.8% <100.0%> (-0.2%) ⬇️
...r/src/simcore_service_webserver/projects/plugin.py 100.0% <100.0%> (ø)

... and 689 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 merged commit 869a08d into ITISFoundation:master Jun 21, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 22, 2023
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants