Skip to content

🗃️ adding minor projects comments table changes + forgotten migration #4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Jun 21, 2023

What do these changes do?

  • 🗃️ adding minor projects comments table changes + forgotten migration

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 21, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Watermelon milestone Jun 21, 2023
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Jun 21, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 21, 2023 13:09
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #4395 (f95a323) into master (6b3bd46) will increase coverage by 2.5%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4395     +/-   ##
========================================
+ Coverage    84.8%   87.3%   +2.5%     
========================================
  Files         951     849    -102     
  Lines       40645   37499   -3146     
  Branches     1006     461    -545     
========================================
- Hits        34496   32770   -1726     
+ Misses       5918    4614   -1304     
+ Partials      231     115    -116     
Flag Coverage Δ
integrationtests 67.9% <ø> (-0.2%) ⬇️
unittests 84.6% <100.0%> (+2.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core_postgres_database/models/projects_comments.py 100.0% <100.0%> (ø)

... and 201 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) June 21, 2023 13:49
@pcrespov pcrespov requested a review from GitHK June 21, 2023 14:02
@codeclimate
Copy link

codeclimate bot commented Jun 21, 2023

Code Climate has analyzed commit f95a323 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov disabled auto-merge June 21, 2023 18:47
@pcrespov pcrespov merged commit 48d29cd into ITISFoundation:master Jun 21, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 22, 2023
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants