Skip to content

🎨 Redesign: Study information page #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jun 22, 2023
Merged

🎨 Redesign: Study information page #4396

merged 28 commits into from
Jun 22, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 21, 2023 •
edited
Loading

What do these changes do?

This PR redesigns the Study Large and Medium views.

Study Large:

  • More compact grid
  • Titles in capitals and shorter
  • Study Id in a button
  • Disable Services auto start option right below the Open button

Study Medium:

  • More compact grid
  • Titles in capitals and shorter

Bonus:

  • Make sure Study properties are bound to Study Large and Medium views
  • Study preview:
    • Do not show it if study is empty
    • Do not show the Nodes tree if it's a mononode study

Before (Study L):
image

After (Study L):
image

Before (Study M):
image

After (Study M):
image

Related issue/s

related to ITISFoundation/osparc-issues#979

How to test

DevOps Checklist

@odeimaiz odeimaiz self-assigned this Jun 21, 2023
@odeimaiz odeimaiz added this to the Watermelon milestone Jun 21, 2023
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Jun 21, 2023
@odeimaiz odeimaiz marked this pull request as ready for review June 22, 2023 08:56
@odeimaiz odeimaiz changed the title WIP 🎨 Redesign: Study/Service information page 🎨 Redesign: Study information page Jun 22, 2023
sanderegg
sanderegg approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) June 22, 2023 09:51
mguidon
mguidon approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌶️

@odeimaiz odeimaiz disabled auto-merge June 22, 2023 09:59
pcrespov
pcrespov reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

elisabettai
elisabettai approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UX Team approves.

In Study L, you haven't move "TAGS" to the right in the end. 😉

@odeimaiz
Copy link
Member Author

The UX Team approves.

In Study L, you haven't move "TAGS" to the right in the end. 😉

I never said that I plan to move them (;

@codeclimate
Copy link

codeclimate bot commented Jun 22, 2023

Code Climate has analyzed commit 9f33d8d and detected 0 issues on this pull request.

View more on Code Climate.

@odeimaiz odeimaiz enabled auto-merge (squash) June 22, 2023 12:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit b537b67 into ITISFoundation:master Jun 22, 2023
@pcrespov pcrespov mentioned this pull request Jun 27, 2023
Closed
16 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 12, 2023
Closed
36 tasks
@odeimaiz odeimaiz deleted the redesign/info-page branch August 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK approved these changes

@elisabettai elisabettai elisabettai approved these changes

@mguidon mguidon mguidon approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@SCA-ZMT SCA-ZMT Awaiting requested review from SCA-ZMT

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Watermelon
Development

Successfully merging this pull request may close these issues.
7 participants
@odeimaiz @GitHK @elisabettai @pcrespov @mguidon @sanderegg @matusdrobuliak66