-
Notifications
You must be signed in to change notification settings - Fork 29
🐛Autoscaling: fix listing of nodes with common prefix #4410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Autoscaling: fix listing of nodes with common prefix #4410
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4410 +/- ##
=========================================
+ Coverage 64.5% 69.3% +4.7%
=========================================
Files 728 415 -313
Lines 33961 21675 -12286
Branches 334 173 -161
=========================================
- Hits 21931 15027 -6904
+ Misses 11956 6599 -5357
+ Partials 74 49 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Code Climate has analyzed commit 6d7e6e1 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks a lot for the quick fix! Should we hotfix to staging and/or prod?
services/autoscaling/src/simcore_service_autoscaling/utils/utils_docker.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments
What do these changes do?
Related issue/s
How to test
DevOps Checklist