Skip to content

🐛Autoscaling: fix listing of nodes with common prefix #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 23, 2023

What do these changes do?

Related issue/s

How to test

make devenv
cd services/autoscaling
make install-dev
make test-dev

DevOps Checklist

@sanderegg sanderegg self-assigned this Jun 23, 2023
@sanderegg sanderegg added this to the Watermelon milestone Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #4410 (6d7e6e1) into master (d851641) will increase coverage by 4.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4410      +/-   ##
=========================================
+ Coverage    64.5%   69.3%    +4.7%     
=========================================
  Files         728     415     -313     
  Lines       33961   21675   -12286     
  Branches      334     173     -161     
=========================================
- Hits        21931   15027    -6904     
+ Misses      11956    6599    -5357     
+ Partials       74      49      -25     
Flag Coverage Δ
integrationtests 67.9% <ø> (+15.9%) ⬆️
unittests 98.0% <100.0%> (+17.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_service_autoscaling/utils/utils_docker.py 100.0% <100.0%> (ø)

... and 496 files with indirect coverage changes

@codeclimate
Copy link

codeclimate bot commented Jun 23, 2023

Code Climate has analyzed commit 6d7e6e1 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg marked this pull request as ready for review June 23, 2023 08:16
@sanderegg sanderegg requested a review from pcrespov as a code owner June 23, 2023 08:16
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot for the quick fix! Should we hotfix to staging and/or prod?

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

@sanderegg sanderegg merged commit 8fcf17d into ITISFoundation:master Jun 23, 2023
@sanderegg sanderegg deleted the bugfix/properly-list-docker-nodes branch June 23, 2023 08:47
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 12, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate issue in autoscaling where the wrong node has been removed
5 participants