♻️Storage API specs are now autogenerated 🚨 #4413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
added
a:storage
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #4413 +/- ##
========================================
- Coverage 86.2% 85.3% -0.9%
========================================
Files 995 911 -84
Lines 42595 40840 -1755
Branches 1009 845 -164
========================================
- Hits 36730 34872 -1858
- Misses 5633 5771 +138
+ Partials 232 197 -35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 2 commits
June 23, 2023 16:22
added 2 commits
June 26, 2023 10:14
added 2 commits
June 26, 2023 10:36
matusdrobuliak66
approved these changes
Jun 26, 2023
pcrespov
reviewed
Jun 26, 2023
sanderegg
approved these changes
Jun 26, 2023
added 4 commits
June 26, 2023 11:06
pcrespov
approved these changes
Jun 26, 2023
|
Code Climate has analyzed commit 3b2ae22 and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
GitHK
changed the title
This was referenced Jun 27, 2023
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
NOTE: the diff is big, but most of it is yaml changes.
If there is one spec file to inspect, that would be
api/specs/webserver/openapi-storage.yaml✨
api/specs/storage/openapi.yamlis now automatically generated and contains all endpoints storage exposes✨
api/specs/webserver/openapi-storage.yamlis no longer handled manually and generated from previously out of date code♻️ Adjusted tests using the OpenAPI specs
🚨 check interface in master for file uploads via file picker that it works
Related issue/s
storagehandles directories 🚨 #4377How to test
DevOps Checklist