Skip to content

♻️Maintenance: webserver openapi users now auto-generated #4424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 27, 2023

What do these changes do?

  • openapi-users.yaml is now auto-generated via fastapi
  • openapi-user.yaml --> openapi-users.yaml
  • removed unused PUT /me/profile

Related issue/s

Bonus:

How to test

DevOps Checklist

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pair reviewed

@sanderegg sanderegg force-pushed the maintenance/webserver-openapi-user branch from dce228f to 9d9ea11 Compare June 27, 2023 09:06
@sanderegg sanderegg force-pushed the maintenance/webserver-openapi-user branch from 9d9ea11 to 38af60d Compare June 27, 2023 09:09
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #4424 (4d36014) into master (8b57f1c) will increase coverage by 0.3%.
The diff coverage is 95.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4424     +/-   ##
========================================
+ Coverage    84.8%   85.1%   +0.3%     
========================================
  Files         996     996             
  Lines       42664   42675     +11     
  Branches     1012    1012             
========================================
+ Hits        36180   36327    +147     
+ Misses       6262    6113    -149     
- Partials      222     235     +13     
Flag Coverage Δ
integrationtests 61.1% <54.2%> (+9.1%) ⬆️
unittests 83.8% <95.2%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...imcore_service_webserver/security/_access_roles.py 100.0% <ø> (ø)
...ver/src/simcore_service_webserver/users/_tokens.py 66.6% <72.7%> (-28.4%) ⬇️
...r/src/simcore_service_webserver/users/_handlers.py 97.7% <97.5%> (+1.0%) ⬆️
.../simcore_service_webserver/users/_notifications.py 100.0% <100.0%> (ø)
...rver/src/simcore_service_webserver/users/plugin.py 100.0% <100.0%> (ø)
...ver/src/simcore_service_webserver/users/schemas.py 98.1% <100.0%> (+<0.1%) ⬆️

... and 66 files with indirect coverage changes

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@codeclimate
Copy link

codeclimate bot commented Jun 27, 2023

Code Climate has analyzed commit 4d36014 and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg merged commit 03dc50a into ITISFoundation:master Jun 27, 2023
@sanderegg sanderegg deleted the maintenance/webserver-openapi-user branch June 27, 2023 12:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gunicorn needs --timeout=90 to properly start webserver
4 participants