Skip to content

🎨🐛Maintenance: fix CI build image issue #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 29, 2023

What do these changes do?

  • fixes Flaky build docker images #4398, the last step in the Dockerfile is slightly different for each image, therefore use the sharing=private (private creates a new mount if there are multiple writers)
  • improves Ruff configuration and allow ruffing per package/service

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Jun 29, 2023
@sanderegg sanderegg added this to the Watermelon milestone Jun 29, 2023
@sanderegg sanderegg self-assigned this Jun 29, 2023
@sanderegg sanderegg requested review from pcrespov and GitHK as code owners June 29, 2023 08:15
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sharing=caringprivate

Thanks a lot

@sanderegg sanderegg force-pushed the maintenance/fix-build-image-issue branch from f683b47 to fcd0d88 Compare June 29, 2023 08:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jun 29, 2023

Code Climate has analyzed commit fcd0d88 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #4434 (fcd0d88) into master (c51bb02) will increase coverage by 2.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4434      +/-   ##
=========================================
+ Coverage    86.3%   89.1%    +2.7%     
=========================================
  Files         892     657     -235     
  Lines       39945   29601   -10344     
  Branches     1008       0    -1008     
=========================================
- Hits        34508   26376    -8132     
+ Misses       5204    3225    -1979     
+ Partials      233       0     -233     
Flag Coverage Δ
integrationtests 66.8% <ø> (-0.9%) ⬇️
unittests 86.8% <ø> (+3.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 439 files with indirect coverage changes

@sanderegg sanderegg merged commit 1251af4 into ITISFoundation:master Jun 29, 2023
@sanderegg sanderegg deleted the maintenance/fix-build-image-issue branch June 29, 2023 09:07
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 12, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky build docker images
4 participants