Skip to content

♻️ Renames osparc environments as osparc variables and secrets #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 30, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 30, 2023

What do these changes do?

After discussion with @sanderegg, we decided to rename "osparc environments" as "osparc variables and secrets" since it is more informative. Here an usage example:

specs = {
    "x": "$OSPARC_VARIABLE_X",
    "my_secret": {"mypassword": "$OSPARC_VARIABLE_VENDOR_SECRET_MYPASSWORD"},
}
specs1 = await substitute_vendor_secrets_in_specs(app, specs, **context)
assert specs1 == {
    "x": "$OSPARC_VARIABLE_X",
    "my_secret": {"mypassword": "foo"},
}

specs2 = await resolve_and_substitute_session_variables_in_specs(app, specs1, **context)
assert specs2 == {
    "x": "3",
    "my_secret": {"mypassword": "foo"},
}

Related issue/s

How to test

DevOps

None

@pcrespov pcrespov changed the title Is3565/rename oenvs as o2vars ♻️ Renames osparc environments as osparc variables and secrets Jun 30, 2023
@pcrespov pcrespov self-assigned this Jun 30, 2023
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jun 30, 2023
@pcrespov pcrespov added this to the Watermelon milestone Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #4443 (4f6bbae) into master (351090a) will increase coverage by 0.4%.
The diff coverage is 79.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4443     +/-   ##
========================================
+ Coverage    86.2%   86.6%   +0.4%     
========================================
  Files         999     883    -116     
  Lines       42789   39143   -3646     
  Branches     1016     579    -437     
========================================
- Hits        36896   33921   -2975     
+ Misses       5659    5085    -574     
+ Partials      234     137     -97     
Flag Coverage Δ
integrationtests 65.5% <62.5%> (-2.2%) ⬇️
unittests 84.3% <79.4%> (+0.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ector_v2/modules/osparc_variables_substitutions.py 55.3% <64.7%> (ø)
...core_service_director_v2/utils/osparc_variables.py 95.4% <85.7%> (ø)
...ary/src/models_library/utils/specs_substitution.py 96.8% <100.0%> (-0.1%) ⬇️
...ry/src/models_library/utils/string_substitution.py 84.0% <100.0%> (ø)
..._postgres_database/models/services_environments.py 100.0% <100.0%> (ø)
...rc/simcore_service_director_v2/core/application.py 97.3% <100.0%> (ø)

... and 129 files with indirect coverage changes

@pcrespov pcrespov enabled auto-merge (squash) June 30, 2023 12:00
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jun 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jun 30, 2023

Code Climate has analyzed commit 4f6bbae and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov merged commit 56bda73 into ITISFoundation:master Jun 30, 2023
@pcrespov pcrespov deleted the is3565/rename-oenvs-as-o2vars branch July 3, 2023 09:09
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 12, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants