Skip to content

🐛upgrade dask-sidecar cuda version to properly detect GPU nodes #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

What do these changes do?

nvidia/cuda:10.0-base has been removed from Dockerhub.

upgraded to latest version which is nvidia/cuda:12.2.0-base-ubuntu22.04

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label Jul 6, 2023
@sanderegg sanderegg added this to the Watermelon milestone Jul 6, 2023
@sanderegg sanderegg self-assigned this Jul 6, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 6, 2023

Code Climate has analyzed commit e4e769f and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please!

@sanderegg sanderegg enabled auto-merge (squash) July 6, 2023 11:29
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #4466 (e4e769f) into master (d7f1575) will decrease coverage by 18.8%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4466      +/-   ##
=========================================
- Coverage    85.6%   66.9%   -18.8%     
=========================================
  Files         910     386     -524     
  Lines       39155   20274   -18881     
  Branches      787       0     -787     
=========================================
- Hits        33537   13568   -19969     
- Misses       5436    6706    +1270     
+ Partials      182       0     -182     
Flag Coverage Δ
integrationtests 65.9% <ø> (-2.3%) ⬇️
unittests 93.1% <100.0%> (+9.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-sidecar/src/simcore_service_dask_sidecar/utils.py 60.3% <100.0%> (+0.6%) ⬆️

... and 758 files with indirect coverage changes

@sanderegg sanderegg merged commit 4ecc58b into ITISFoundation:master Jul 6, 2023
@sanderegg sanderegg deleted the maintenance/upgrade-nvidia-cuda branch July 6, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants