✨ Frontend: wait for backend's confirmation before removing a node #4639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
requested review from
GitHK,
mrnicegyu11,
elisabettai,
pcrespov,
mguidon,
sanderegg,
YuryHrytsuk,
matusdrobuliak66 and
SCA-ZMT
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit b569d7a and detected 0 issues on this pull request. View more on Code Climate. |
pcrespov
approved these changes
Aug 23, 2023
|
very nice! thanks! |
16 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR follows #4617
When
DELETEing a node, the backend needs to first do some operations before really deleting it from the pipeline. This PR makes the frontend wait for the backend's response.Related issue/s
How to test
DevOps Checklist