Skip to content

✨ Frontend: open Wallets view after log in #4649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 24, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 23, 2023

What do these changes do?

In order to provide an easier way to access the wallets' state, buy credits or check the usage overview, this PR supports the wallets anchor.

If a user accesses the application using a URL that follows this convention...
https://sim4life.io/#/wallets

  • ... if the user was already logged in, the Wallets view will pop up.
  • ... if the user wasn't logged it yet, after logging in the Wallets view will pop up.

This Wallets/Credits view, as well as the log in page and the whole application, will later be adapted to follow the new marketing website's style. This way, a link to the wallets or buy-credits could be provided in the marketing website and when users click on it they will have the feeling that they are still in the same (actually similar) website.

Already logged in:
WalletLink2

Not logged in it yet:
WalletLink

Related issue/s

related to ITISFoundation/osparc-issues#1027

How to test

DevOps Checklist

@odeimaiz odeimaiz self-assigned this Aug 23, 2023
@odeimaiz odeimaiz changed the title ✨ Forntend: open Wallets view after log in ✨ Frontend: open Wallets view after log in Aug 23, 2023
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:✨new-feature labels Aug 23, 2023
@odeimaiz odeimaiz added this to the Baklava milestone Aug 23, 2023
@odeimaiz odeimaiz requested a review from bisgaard-itis August 23, 2023 14:40
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Just some random thoughts/questions: buying credits will be handled by the marketing website, right? In that case I guess we should have a link that from osparc that goes to that page on the marketing website "subpage".

@odeimaiz odeimaiz enabled auto-merge (squash) August 23, 2023 15:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 24, 2023

Code Climate has analyzed commit eb22047 and detected 0 issues on this pull request.

View more on Code Climate.

@odeimaiz odeimaiz merged commit a071546 into ITISFoundation:master Aug 24, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
@odeimaiz odeimaiz deleted the feature/wallets-direct-link branch August 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants