-
Notifications
You must be signed in to change notification settings - Fork 30
✨RabbitMQ: Add RPC decorator for server side #4682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨RabbitMQ: Add RPC decorator for server side #4682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4682 +/- ##
========================================
- Coverage 86.7% 84.6% -2.2%
========================================
Files 1064 853 -211
Lines 44837 37595 -7242
Branches 1021 538 -483
========================================
- Hits 38910 31814 -7096
+ Misses 5698 5667 -31
+ Partials 229 114 -115
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1790d63
to
3f7b243
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice step. The routers are great addition to simplify usage.
I added a note to the general concept of "rabbit_rpc" . I think the test shows clearly things that can be improved in subsequent PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
f76d302
to
f2ac0aa
Compare
Code Climate has analyzed commit f2ac0aa and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
@expose
decorator to use on methods to expose as RPC methodsNOTE: this provides a convenient way to expose RPC functions. NOT yet a convenient way to provide the client side. this might come later. baby steps as someone much smarter than me said.
This PR allows to reduce the complexity of #4602
Related issue/s
How to test
DevOps Checklist