Skip to content

✨RabbitMQ: Add RPC decorator for server side #4682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 30, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 29, 2023

What do these changes do?

  • provides a @expose decorator to use on methods to expose as RPC methods

NOTE: this provides a convenient way to expose RPC functions. NOT yet a convenient way to provide the client side. this might come later. baby steps as someone much smarter than me said.

This PR allows to reduce the complexity of #4602

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:services-library issues on packages/service-libs label Aug 29, 2023
@sanderegg sanderegg added this to the Baklava milestone Aug 29, 2023
@sanderegg sanderegg self-assigned this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #4682 (f2ac0aa) into master (f3ac846) will decrease coverage by 2.2%.
The diff coverage is 97.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4682     +/-   ##
========================================
- Coverage    86.7%   84.6%   -2.2%     
========================================
  Files        1064     853    -211     
  Lines       44837   37595   -7242     
  Branches     1021     538    -483     
========================================
- Hits        38910   31814   -7096     
+ Misses       5698    5667     -31     
+ Partials      229     114    -115     
Flag Coverage Δ
integrationtests 59.3% <ø> (-6.2%) ⬇️
unittests 83.9% <97.6%> (-0.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ackages/service-library/src/servicelib/rabbitmq.py 94.4% <88.8%> (+0.2%) ⬆️
.../service-library/src/servicelib/background_task.py 97.8% <100.0%> (+<0.1%) ⬆️
...es/service-library/src/servicelib/logging_utils.py 72.4% <100.0%> (+0.1%) ⬆️
...vice-library/src/servicelib/rabbitmq_rpc_router.py 100.0% <100.0%> (ø)

... and 254 files with indirect coverage changes

@sanderegg sanderegg marked this pull request as ready for review August 29, 2023 16:18
@sanderegg sanderegg requested a review from pcrespov as a code owner August 29, 2023 16:18
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice step. The routers are great addition to simplify usage.

I added a note to the general concept of "rabbit_rpc" . I think the test shows clearly things that can be improved in subsequent PRs.

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeclimate
Copy link

codeclimate bot commented Aug 30, 2023

Code Climate has analyzed commit f2ac0aa and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:services-library issues on packages/service-libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants