♻️ Feedback on payments plugin and service

[pcrespov]

What do these changes do?

Implements feedback after review with @odeimaiz

• Fake mechanism (for prototyping)
  • increase success rate on possible outcomes (before it was faking "falure" too much)
  • return fake payment-method values
• API of the services/payments version: 1.0.0 → 1.1.0
  • payments ACK includes payment_method_id in case user marks save during payment flow
• init step in init-prompt-ack flow responds with ACCEPTED instead of CREATED to indicate that the request has been accepted for processing but has not been completed
• sends notifications to front-end when payment-method is ACKED (i.e. completes Init-Prompt-Ack flow)

Detail on init-pro-ack flow

Related issue/s

• Iterating on sim4life.io - WP10: Payment Gateway osparc-issues#1027

How to test

• services/web/server/tests/unit/with_dbs/03/wallets/payments/test_payments_methods.py

DevOps

[codecov]

Codecov Report

Merging #4763 (c7d45d7) into master (0bf85e1) will decrease coverage by 1.9%.
The diff coverage is 86.6%.

@@            Coverage Diff            @@
##           master   #4763      +/-   ##
=========================================
- Coverage    87.0%   85.2%    -1.9%     
=========================================
  Files        1131     591     -540     
  Lines       47220   27719   -19501     
  Branches     1014     299     -715     
=========================================
- Hits        41107   23620   -17487     
+ Misses       5886    4041    -1845     
+ Partials      227      58     -169     

Flag	Coverage Δ
integrationtests	?
unittests	85.2% <86.6%> (+0.4%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
.../simcore_service_webserver/payments/_methods_db.py	85.5% <ø> (ø)
...r/src/simcore_service_webserver/payments/_tasks.py	48.4% <50.0%> (+4.1%)	⬆️
...ervice_payments/models/schemas/acknowledgements.py	100.0% <100.0%> (ø)
...simcore_service_webserver/payments/_methods_api.py	100.0% <100.0%> (ø)
...rc/simcore_service_webserver/payments/_socketio.py	100.0% <100.0%> (ø)
...src/simcore_service_webserver/socketio/messages.py	94.7% <100.0%> (+0.1%)	⬆️
...re_service_webserver/wallets/_payments_handlers.py	99.1% <100.0%> (ø)

... and 609 files with indirect coverage changes

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codeclimate]

Code Climate has analyzed commit c7d45d7 and detected 0 issues on this pull request.

View more on Code Climate.

[matusdrobuliak66]

👍