-
Notifications
You must be signed in to change notification settings - Fork 28
✨payments
service: notification of payments to the front-end via socketio
#5057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨payments
service: notification of payments to the front-end via socketio
#5057
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5057 +/- ##
=========================================
+ Coverage 79.9% 86.8% +6.9%
=========================================
Files 1226 669 -557
Lines 50098 31971 -18127
Branches 1124 577 -547
=========================================
- Hits 40051 27767 -12284
+ Misses 9807 4072 -5735
+ Partials 240 132 -108
Flags with carried forward coverage won't be shown. Click here to find out more.
|
95f8362
to
03e59c0
Compare
03e59c0
to
504d5d0
Compare
payments
service notifies front-end via socketio
1fc2968
to
3552945
Compare
payments
service notifies front-end via socketiopayments
service: notification of payments to the front-end via socketio
payments
service: notification of payments to the front-end via socketiopayments
service: notification of payments to the front-end via socketio
payments
service: notification of payments to the front-end via socketiopayments
service: notification of payments to the front-end via socketio
services/payments/src/simcore_service_payments/services/payments.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/wallets/_payments_handlers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
69aef6f
to
6874686
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! thanks
966190b
to
453d955
Compare
Code Climate has analyzed commit 453d955 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
teardown = asyncio.Event() | ||
|
||
server = TestServer(aiohttp_app, port=aiohttp_unused_port()) | ||
t = asyncio.create_task(_lifespan(server, setup, teardown), name="server-lifespan") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pcrespov sorry, I didn't manage to review before the PR got in. But I really like this and I think it would be very useful to have this somewhere in one of the packages. I guess one could do this with any of the test servers we are using, right?
What do these changes do?
This PR implements socketio link between the
payments
and thewebserver
services. This link is used to notify payment completion to the front-end.NOTE: This PR adds the functionality but the two services are still not connected. This will be done in a separate PR !
payments/gateway
:gateway/openapi.json
scripts
in an example implementation that can be used for development. NOTE that this is installed with thepayments
package and therefore available in the$PATH
after installation. i.e. this will create a gatewaycd services/payments make install-dev example_payment_gateway.py run
webserver
'swallets/_payments_handlers.py
: Improves notification with a small delay in payment w/ payment-method ack which is directly performed at the web-servers handler (remember that this type of payment is done in one call and not using the init-prompt-ack flow)Related issue/s
How to test
services/payments/tests/unit/test_services_socketio.py
Dev Checklist
DevOps
None