Skip to content

added versions to requirements in storage and sidecar #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2019
Merged

added versions to requirements in storage and sidecar #513

merged 2 commits into from
Jan 8, 2019

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 8, 2019 •
edited
Loading

What do these changes do?

  • fixes travis build issue with versions.
    when no version specified in requirements.txt, pip installs the latest version only if none was installed before

Bonus:

  • added a badge for coveralls

Related issue number

closes #512

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@sanderegg sanderegg self-assigned this Jan 8, 2019
@ghost ghost added the review label Jan 8, 2019
@sanderegg sanderegg merged commit a843902 into ITISFoundation:master Jan 8, 2019
@ghost ghost removed the review label Jan 8, 2019
@sanderegg sanderegg deleted the fix_storage_dependencies branch January 8, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeimaiz odeimaiz odeimaiz approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@sanderegg sanderegg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

travis build fails in storage
2 participants
@sanderegg @odeimaiz