🎨 Frontend: Credits indicator only visible in warning zone by default (🚨) #5897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
odeimaiz
requested review from
pcrespov,
sanderegg,
GitHK,
matusdrobuliak66,
jsaq007 and
ignapas
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5897 +/- ##
=========================================
- Coverage 84.5% 81.4% -3.1%
=========================================
Files 10 561 +551
Lines 214 28228 +28014
Branches 25 205 +180
=========================================
+ Hits 181 23003 +22822
- Misses 23 5174 +5151
- Partials 10 51 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
approved these changes
May 30, 2024
services/web/server/src/simcore_service_webserver/users/_preferences_models.py
Show resolved
Hide resolved
sanderegg
approved these changes
May 30, 2024
odeimaiz
changed the title
ignapas
approved these changes
May 30, 2024
|
17 tasks
|
For the Release Notes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR will only affect the new users.
🚨 If we want to change the default value of the existing users, we need to go through the DB, either deleting
WalletIndicatorVisibilityFrontendUserPreferencepreference entries or changing their value (I believe there is a sql script somewhere).demo with user with no
WalletIndicatorVisibilityFrontendUserPreferenceentry in the DB:Related issue/s
closes ITISFoundation/osparc-issues#1474
How to test
Dev-ops checklist