-
Notifications
You must be signed in to change notification settings - Fork 29
♻️ Maintenance: pytest-simcore
initial cleanup
#5986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Maintenance: pytest-simcore
initial cleanup
#5986
Conversation
d3a6cfc
to
3c1f622
Compare
pytest-simcore
cleanup
pytest-simcore
cleanuppytest-simcore
cleanup
pytest-simcore
cleanuppytest-simcore
initial cleanup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5986 +/- ##
=========================================
+ Coverage 84.5% 87.8% +3.2%
=========================================
Files 10 1415 +1405
Lines 214 58095 +57881
Branches 25 1340 +1315
=========================================
+ Hits 181 51047 +50866
- Misses 23 6758 +6735
- Partials 10 290 +280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I guess. If we change the convention why don't we have a PR which changes all of them?
@GitHK there were too many changes involved so I will be doing it in successive PRs |
For future changes, if someone makes a decision, it would be way better to apply it to all the involved pieces of code instead of having it spread out like this. |
@GitHK This PR is the "decision process". You have a saying if you agree or not on this. That is what I mention in the description. Yet another reason not to do all the changes at once :-) |
a34ff6e
to
46b089a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks a lot for the effort
What do these changes do?
Following a discussion with @sanderegg on
pytest-simcore
, this PR performs an initial cleanup of the module according to our some proposed conventions. The mid-term goal is to simplify common fixtures and tests. However, since the changes are quite extensive, we are breaking them down into separate steps. This approach also allows everyone to stay informed and discuss the new conventions as we proceed.pytest_plugins
must be sorted alphabeticalpytest_simcore.helpers.utils_
is redundant. We will droputils_
.logging_utils
andplaywright_utils
moved topytest_simcore.helpers
nowpytest_addoption
and its associated fixture must be together in the associated plugin module (e.g.--keep-docker-up
andkeep_docker_up
)packages/pytest-simcore/src/pytest_simcore/monkeypatch_extra.py
: monkeypatch must have function context!Related issue/s
How to test
All tests should run as before
Dev-ops checklist