Skip to content

🎨 Maintenance: Add new concurrency tooling #5997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 25, 2024

What do these changes do?

Reduced size of #5981

This PR brings learnings from this article:
Run concurrent asyncio awaitables without overloading the event loop. Tasks are created on the fly and based on need and are limited in number.

driving test: test_utils.py in servicelib.

Bonus:

  • mypy script now uses uv
  • fixed dynamic-sidecar new mypy issue by ignoring it @GitHK

NOTE: I will not move that to async_utils.py yet to reduce noise.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:services-library issues on packages/service-libs label Jun 25, 2024
@sanderegg sanderegg added this to the South Island Iced Tea milestone Jun 25, 2024
@sanderegg sanderegg self-assigned this Jun 25, 2024
@sanderegg sanderegg requested a review from pcrespov as a code owner June 25, 2024 21:00
@sanderegg sanderegg requested review from GitHK and bisgaard-itis June 25, 2024 21:00
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.2%. Comparing base (cafbf96) to head (f72f655).
Report is 299 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5997      +/-   ##
=========================================
+ Coverage    84.5%   88.2%    +3.6%     
=========================================
  Files          10    1362    +1352     
  Lines         214   56249   +56035     
  Branches       25    1206    +1181     
=========================================
+ Hits          181   49626   +49445     
- Misses         23    6364    +6341     
- Partials       10     259     +249     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 86.2% <100.0%> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/service-library/src/servicelib/utils.py 92.8% <100.0%> (ø)
...mcore_service_dynamic_sidecar/modules/nodeports.py 31.8% <ø> (ø)

... and 1335 files with indirect coverage changes

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some minor comments form me

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thx for bringing this to our attention.

@sanderegg sanderegg merged commit b84b85f into ITISFoundation:master Jun 26, 2024
56 checks passed
@sanderegg sanderegg deleted the maintenance/asyncio-use-wait branch June 26, 2024 08:45
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:services-library issues on packages/service-libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants