-
Notifications
You must be signed in to change notification settings - Fork 28
🎨 Maintenance: Add new concurrency tooling #5997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Maintenance: Add new concurrency tooling #5997
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5997 +/- ##
=========================================
+ Coverage 84.5% 88.2% +3.6%
=========================================
Files 10 1362 +1352
Lines 214 56249 +56035
Branches 25 1206 +1181
=========================================
+ Hits 181 49626 +49445
- Misses 23 6364 +6341
- Partials 10 259 +249
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, some minor comments form me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thx for bringing this to our attention.
What do these changes do?
Reduced size of #5981
This PR brings learnings from this article:
Run concurrent asyncio awaitables without overloading the event loop. Tasks are created on the fly and based on need and are limited in number.
driving test: test_utils.py in servicelib.
Bonus:
NOTE: I will not move that to async_utils.py yet to reduce noise.
Related issue/s
How to test
Dev-ops checklist