Skip to content

🎨 Improve load test framework (yet again) #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 11, 2024

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jul 10, 2024

What do these changes do?

  • When fixing the web responsivity test I realize that the setup I had done for handling settings for the load tests was unfortunate because it added a dependencies (psutil) which is complicated to install on certain linux distributions (like the docker containers where we run some of our tests).
  • Moreover, I realized that the design was over complicated and the core functionality which would actually be useful could be easily factored out. This is done in this PR.

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Jul 10, 2024
@bisgaard-itis bisgaard-itis added the t:maintenance Some planned maintenance work label Jul 10, 2024
@bisgaard-itis bisgaard-itis added this to the Tom Bombadil milestone Jul 10, 2024
@bisgaard-itis bisgaard-itis marked this pull request as ready for review July 10, 2024 21:55
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks more simple, which is a very good thing. Thx

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.6%. Comparing base (cafbf96) to head (6bf806e).
Report is 336 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (cafbf96) and HEAD (6bf806e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cafbf96) HEAD (6bf806e)
unittests 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6051      +/-   ##
=========================================
- Coverage    84.5%   63.6%   -21.0%     
=========================================
  Files          10     562     +552     
  Lines         214   28529   +28315     
  Branches       25     205     +180     
=========================================
+ Hits          181   18153   +17972     
- Misses         23   10325   +10302     
- Partials       10      51      +41     
Flag Coverage Δ
integrationtests 63.6% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 572 files with indirect coverage changes

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) July 11, 2024 08:50
@bisgaard-itis bisgaard-itis merged commit 5a0a74f into ITISFoundation:master Jul 11, 2024
56 checks passed
@bisgaard-itis bisgaard-itis deleted the refactor-load-tests branch July 11, 2024 09:32
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Jul 17, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants