Skip to content

🎨 web-api services api response includes manifest info (part 5) #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 16, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 15, 2024

What do these changes do?

Connects manifest to services web-api response (requirement for UI)

The service metadata returned by the API is composed of two intersecting parts, namely a "published" and an "editable" parts. The first comes from the manifest (i.e. metadata from services in the docker registry and function-services) and the second comes from the services_meta_data table.

This PR completes the service meta-data returned in the API by accessing and merging the "published" part. This part includes fields like inputs/outputs, etc

Extras

  • 🔨 prints actual docker-compose specs used in the tests

Related issue/s

How to test

  • Main driving test services/catalog/tests/unit/with_dbs/test_services_services_api.py
  • Manual testing /dev/catalog/services/* entrypoints using swagger site
    • set WEBSERVER_DEV_FEATURES_ENABLED=1 in .env
    • deploy
    • Execute entrypoint and should receive a complete answer
      image

Following PR will address:

  • evaluate and add compatibility field in response body

Dev-ops checklist

@pcrespov pcrespov self-assigned this Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.0%. Comparing base (cafbf96) to head (0c36058).
Report is 350 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6061      +/-   ##
=========================================
+ Coverage    84.5%   88.0%    +3.5%     
=========================================
  Files          10    1438    +1428     
  Lines         214   59148   +58934     
  Branches       25    1409    +1384     
=========================================
+ Hits          181   52106   +51925     
- Misses         23    6746    +6723     
- Partials       10     296     +286     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 86.1% <100.0%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mcore_service_catalog/api/dependencies/services.py 88.0% <ø> (ø)
...g/src/simcore_service_catalog/api/rpc/_services.py 100.0% <100.0%> (ø)
...imcore_service_catalog/db/repositories/services.py 81.3% <100.0%> (ø)
...g/src/simcore_service_catalog/services/director.py 91.9% <ø> (ø)
...g/src/simcore_service_catalog/services/manifest.py 86.1% <100.0%> (ø)
...c/simcore_service_catalog/services/services_api.py 77.9% <100.0%> (ø)

... and 1394 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is5964/rpc-catalog-director branch from 2a45843 to 01bb699 Compare July 15, 2024 17:48
@pcrespov pcrespov changed the title WIP: 🎨 web-api services api includes manifest info (part 5) 🎨 web-api services api includes manifest info (part 5) Jul 16, 2024
@pcrespov pcrespov added the a:catalog catalog service label Jul 16, 2024
@pcrespov pcrespov marked this pull request as ready for review July 16, 2024 08:40
@pcrespov pcrespov requested a review from sanderegg as a code owner July 16, 2024 08:40
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov force-pushed the is5964/rpc-catalog-director branch from 655148c to 72147e3 Compare July 16, 2024 09:09
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Just a question for my understanding. Thanks

@pcrespov pcrespov enabled auto-merge (squash) July 16, 2024 09:28
@pcrespov pcrespov changed the title 🎨 web-api services api includes manifest info (part 5) 🎨 web-api services api includes manifest info (part 4) Jul 16, 2024
@pcrespov pcrespov changed the title 🎨 web-api services api includes manifest info (part 4) 🎨 web-api services api includes manifest info (part 5) Jul 16, 2024
@pcrespov pcrespov changed the title 🎨 web-api services api includes manifest info (part 5) 🎨 web-api services api response includes manifest info (part 5) Jul 16, 2024
@pcrespov pcrespov added this to the Tom Bombadil milestone Jul 16, 2024
@pcrespov pcrespov force-pushed the is5964/rpc-catalog-director branch from 146ad1f to 0c19503 Compare July 16, 2024 11:19
@pcrespov pcrespov force-pushed the is5964/rpc-catalog-director branch from 668e888 to 0c36058 Compare July 16, 2024 13:39
@pcrespov pcrespov disabled auto-merge July 16, 2024 15:41
@pcrespov pcrespov merged commit 0c23386 into ITISFoundation:master Jul 16, 2024
2 checks passed
@pcrespov pcrespov deleted the is5964/rpc-catalog-director branch July 16, 2024 17:08
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Jul 17, 2024
@pcrespov pcrespov restored the is5964/rpc-catalog-director branch July 19, 2024 09:54
@pcrespov pcrespov deleted the is5964/rpc-catalog-director branch July 19, 2024 09:54
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:catalog catalog service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants