-
Notifications
You must be signed in to change notification settings - Fork 29
🎨 web-api services
api response includes manifest info (part 5)
#6061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 web-api services
api response includes manifest info (part 5)
#6061
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6061 +/- ##
=========================================
+ Coverage 84.5% 88.0% +3.5%
=========================================
Files 10 1438 +1428
Lines 214 59148 +58934
Branches 25 1409 +1384
=========================================
+ Hits 181 52106 +51925
- Misses 23 6746 +6723
- Partials 10 296 +286
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2a45843
to
01bb699
Compare
services
api includes manifest info (part 5)services
api includes manifest info (part 5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
655148c
to
72147e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. Just a question for my understanding. Thanks
services
api includes manifest info (part 5)services
api includes manifest info (part 4)
services
api includes manifest info (part 4)services
api includes manifest info (part 5)
services
api includes manifest info (part 5)services
api response includes manifest info (part 5)
146ad1f
to
0c19503
Compare
668e888
to
0c36058
Compare
What do these changes do?
Connects manifest to
services
web-api response (requirement for UI)The service metadata returned by the API is composed of two intersecting parts, namely a "published" and an "editable" parts. The first comes from the manifest (i.e. metadata from services in the docker registry and function-services) and the second comes from the
services_meta_data
table.This PR completes the service meta-data returned in the API by accessing and merging the "published" part. This part includes fields like inputs/outputs, etc
Extras
Related issue/s
How to test
services/catalog/tests/unit/with_dbs/test_services_services_api.py
/dev/catalog/services/*
entrypoints using swagger siteWEBSERVER_DEV_FEATURES_ENABLED=1
in.env
Following PR will address:
compatibility
field in response bodyDev-ops checklist