🎨 [Frontend] UX Cookie Expiration Date #6066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
ignapas
approved these changes
Jul 16, 2024
|
Q: Instead of asking the user to logout, why not to logout the user automatically and show the login page with "session expired. Please login again" as in other tools |
@pcrespov |
GitHK
approved these changes
Jul 16, 2024
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
reported by @newton1985 .
When a computer goes into hibernation, the browser's setTimeout functions, along with other JavaScript timers, are paused. This is because the computer essentially saves the state of everything to disk and then powers off, halting all running processes including the browser.
In order to overcome the long setTimeout issue with hibernation (which was the case for the Cookie Expiration workflow), this PR changes the mechanism. We will now first set the expirationDate as a property and check every minute where we are with regards to the Expiration Date. If the user hibernates and comes back, this every minute check will kick again the continue with the workflow.
Animation with the cookie expiring in 15' and 1" check interval (after logging in, I Sleep the computer for a few seconds):
Related issue/s
How to test
Dev-ops checklist