-
Notifications
You must be signed in to change notification settings - Fork 29
♻️ Preparation of tags for both services and projects 🗃️ #6092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Preparation of tags for both services and projects 🗃️ #6092
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6092 +/- ##
=========================================
+ Coverage 84.5% 95.7% +11.2%
=========================================
Files 10 45 +35
Lines 214 1046 +832
Branches 25 26 +1
=========================================
+ Hits 181 1002 +821
- Misses 23 42 +19
+ Partials 10 2 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
24d3d49
to
17a9d14
Compare
d899624
to
dc8e4a1
Compare
72d6271
to
22b1fad
Compare
...ase/src/simcore_postgres_database/migration/versions/e8057a4a7bb0_new_services_tags_table.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 Lets decide on the naming convention :)
20ae9bc
to
ac8085f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
What do these changes do?
The idea is to reuse the
tags
concept applied to theprojects
ontoservices
. Before starting, we do some preparations to clear the setup-
tags
- ♻️
projects_tags
(renamed fromstudy_tags
): many-to-many relation betweenprojects
andtags
- ✨
services_tags
(new): many-to-many relation betweenservices
andtags
- ♻️
tags_access_rights
(renamed fromtags_to_groups
): : many-to-many relation betweentags
andgroups
withRWD
flagsutils_tags
(pre)repository layer- sql queries
tags_sql
Related issue/s
How to test
Dev-ops checklist