Skip to content

♻️ Preparation of tags for both services and projects 🗃️ #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Aug 27, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 23, 2024

What do these changes do?

The idea is to reuse the tags concept applied to the projects onto services. Before starting, we do some preparations to clear the setup

image

  • 🗃️ renames some postgres models for consistency:
    - tags
    - ♻️ projects_tags (renamed from study_tags): many-to-many relation between projects and tags
    - ✨ services_tags (new): many-to-many relation between services and tags
    - ♻️ tags_access_rights (renamed from tags_to_groups): : many-to-many relation between tags and groups with RWD flags
  • ♻️ splits utils_tags (pre)repository layer
    - sql queries tags_sql

Related issue/s

How to test

cd packages/postgres-database
pytest -vv tests/test_*tags*.py

Dev-ops checklist

  • 🗃️ changes in the database
    • new database table (see above for details)
    • renames some tables and columns (see above for details)

@pcrespov pcrespov added this to the Tom Bombadil milestone Jul 23, 2024
@pcrespov pcrespov self-assigned this Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.7%. Comparing base (cafbf96) to head (20ae9bc).
Report is 471 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6092      +/-   ##
=========================================
+ Coverage    84.5%   95.7%   +11.2%     
=========================================
  Files          10      45      +35     
  Lines         214    1046     +832     
  Branches       25      26       +1     
=========================================
+ Hits          181    1002     +821     
- Misses         23      42      +19     
+ Partials       10       2       -8     
Flag Coverage Δ
unittests 95.7% <ø> (+11.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is5964/preparation-tags branch from 24d3d49 to 17a9d14 Compare July 24, 2024 16:16
@pcrespov pcrespov modified the milestones: Tom Bombadil, Eisbock Aug 23, 2024
@pcrespov pcrespov force-pushed the is5964/preparation-tags branch 2 times, most recently from d899624 to dc8e4a1 Compare August 23, 2024 11:54
@pcrespov pcrespov changed the title WIP: Is5964/preparation tags ♻️ Preparation of tags for both services and projects Aug 23, 2024
@pcrespov pcrespov added the a:database associated to postgres service and postgres-database package label Aug 23, 2024
@pcrespov pcrespov changed the title ♻️ Preparation of tags for both services and projects ♻️ Preparation of tags for both services and projects 🗃️ Aug 23, 2024
@pcrespov pcrespov force-pushed the is5964/preparation-tags branch 2 times, most recently from 72d6271 to 22b1fad Compare August 26, 2024 15:19
@pcrespov pcrespov marked this pull request as ready for review August 26, 2024 15:34
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Lets decide on the naming convention :)

@pcrespov pcrespov force-pushed the is5964/preparation-tags branch from 20ae9bc to ac8085f Compare August 26, 2024 16:17
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@pcrespov pcrespov mentioned this pull request Aug 26, 2024
1 task
@pcrespov pcrespov enabled auto-merge (squash) August 26, 2024 16:30
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pcrespov pcrespov merged commit 2e2993c into ITISFoundation:master Aug 27, 2024
111 checks passed
@pcrespov pcrespov deleted the is5964/preparation-tags branch August 27, 2024 06:24
@pcrespov pcrespov restored the is5964/preparation-tags branch August 30, 2024 09:55
@pcrespov pcrespov deleted the is5964/preparation-tags branch August 30, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants