Skip to content

♻️Mypy: webserver2 #6200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Aug 20, 2024
Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 16, 2024

What do these changes do?

Completes the webserver mypy errors... (sic)

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Aug 16, 2024
@sanderegg sanderegg added this to the Eisbock milestone Aug 16, 2024
@sanderegg sanderegg self-assigned this Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 81.63265% with 36 lines in your changes missing coverage. Please review.

Project coverage is 88.0%. Comparing base (cafbf96) to head (a2a3fa2).
Report is 453 commits behind head on master.

Files Patch % Lines
...s/models-library/src/models_library/basic_types.py 26.6% 11 Missing ⚠️
...imcore_service_webserver/publications/_handlers.py 12.5% 7 Missing ⚠️
...ages/service-library/src/servicelib/redis_utils.py 40.0% 3 Missing ⚠️
...ore_service_webserver/folders/_folders_handlers.py 50.0% 2 Missing ⚠️
...ervice_webserver/projects/_crud_handlers_models.py 50.0% 2 Missing ⚠️
...c/simcore_service_webserver/projects/_ports_api.py 77.7% 2 Missing ⚠️
...rver/src/simcore_service_webserver/catalog/_api.py 50.0% 1 Missing ⚠️
...c/simcore_service_webserver/login/_registration.py 66.6% 1 Missing ⚠️
...ervice_webserver/meta_modeling/_version_control.py 66.6% 1 Missing ⚠️
.../src/simcore_service_webserver/payments/_events.py 0.0% 1 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6200      +/-   ##
=========================================
+ Coverage    84.5%   88.0%    +3.5%     
=========================================
  Files          10    1315    +1305     
  Lines         214   57129   +56915     
  Branches       25    1138    +1113     
=========================================
+ Hits          181   50320   +50139     
- Misses         23    6563    +6540     
- Partials       10     246     +236     
Flag Coverage Δ
integrationtests 64.9% <53.7%> (?)
unittests 85.9% <80.6%> (+1.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/models_library/api_schemas_webserver/wallets.py 94.7% <100.0%> (ø)
...r/src/simcore_service_webserver/catalog/_models.py 90.4% <100.0%> (ø)
.../server/src/simcore_service_webserver/db/plugin.py 88.8% <100.0%> (ø)
...simcore_service_webserver/dynamic_scheduler/api.py 88.6% <100.0%> (ø)
...rver/src/simcore_service_webserver/email/plugin.py 88.2% <100.0%> (ø)
...rc/simcore_service_webserver/exporter/_handlers.py 95.2% <100.0%> (ø)
...server/src/simcore_service_webserver/groups/_db.py 95.3% <100.0%> (ø)
.../src/simcore_service_webserver/groups/_handlers.py 82.8% <100.0%> (ø)
...es/web/server/src/simcore_service_webserver/log.py 94.4% <100.0%> (ø)
...er/src/simcore_service_webserver/login/_2fa_api.py 84.0% <100.0%> (ø)
... and 43 more

... and 1253 files with indirect coverage changes

@sanderegg sanderegg marked this pull request as ready for review August 19, 2024 15:18
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wau thanks a lot for the effort!! 🥇

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sanderegg sanderegg enabled auto-merge (squash) August 19, 2024 16:50
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for completing this 👍
Found some minor stuff.

Copy link

@sanderegg sanderegg merged commit dc9dc44 into ITISFoundation:master Aug 20, 2024
57 checks passed
@sanderegg sanderegg deleted the mypy/webserver2 branch August 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants