🐛 [Frontend] Fix App mode: Wait until the workbench is deserialized to start #6214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
odeimaiz
requested review from
giancarloromeo,
GitHK,
elisabettai,
pcrespov,
sanderegg and
matusdrobuliak66
elisabettai
approved these changes
Aug 20, 2024
|
jsaq007
approved these changes
Aug 20, 2024
matusdrobuliak66
pushed a commit
that referenced
this pull request
Aug 21, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Since we refactored the
/servicesendpoint, the deserialization of the nodes in the workbench is an asynchronous step (specially when starting a project which its services are not up-to-date). In the App Mode, when starting the slides, it can happen that the workbench is not yet completely deserialized, this makes the slideshow to be shown empty.This PR waits until the workbench is deserialized before the slideshow is started.
Related issue/s
How to test
Dev-ops checklist