Skip to content

🎨 [Frontend] Request Account form for oSPARC 🚨 ⚠️ DEVOPS #6217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 26, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 20, 2024

What do these changes do?

If product vendor's information says that invitation_form and the login configuration says invitation_required, a Request Account form will be displayed (no more is_product_billable checks for this).

RequestAccount

Related issue/s

closes ITISFoundation/osparc-issues#1584

How to test

  • set "invitation_form": true in database (see below)
  • open product's url
  • click invitation
  • you should get the form
  • repeat with "invitation_form": false to obtain either a link (if invitation_url is provided) or an email (if not)

Dev-ops checklist 🚨

  • 🗃️ Add invitation_form: true in products.vendor column of the database. e.g.
{
    "url": "https://acme.com",
    "license_url": "https://acme.com/license",
    "invitation_form": true,
    "name": "ACME",
    "copyright": "© ACME correcaminos",
    "has_landing_page": false
}

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Aug 20, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Aug 20, 2024
@odeimaiz odeimaiz self-assigned this Aug 20, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (d888842).
Report is 470 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6217      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1466    +1456     
  Lines         214   60943   +60729     
  Branches       25    2063    +2038     
=========================================
+ Hits          181   53710   +53529     
- Misses         23    6918    +6895     
- Partials       10     315     +305     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 86.1% <100.0%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/src/simcore_postgres_database/models/products.py 100.0% <100.0%> (ø)
...r/src/simcore_service_webserver/products/_model.py 95.3% <ø> (ø)

... and 1415 files with indirect coverage changes

@pcrespov pcrespov changed the title 🎨 [Frontend] Request Account form for oSPARC 🎨 [Frontend] Request Account form for oSPARC 🚨 Aug 22, 2024
@odeimaiz odeimaiz marked this pull request as ready for review August 26, 2024 08:33
@odeimaiz odeimaiz enabled auto-merge (squash) August 26, 2024 08:40
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thanks!

@elisabettai
Copy link
Collaborator

elisabettai commented Aug 26, 2024

@JavierGOrdonnez, when this reaches production, you might get a json form in the emails from people who request an osparc account. Just add that to the "Preregistration" tab in the PO Center, or ask @pcrespov for more info. 😉

Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run it in the browser but looks ok. I don't expect big surprises

@odeimaiz odeimaiz merged commit 3c0909d into ITISFoundation:master Aug 26, 2024
56 checks passed
@YuryHrytsuk YuryHrytsuk changed the title 🎨 [Frontend] Request Account form for oSPARC 🚨 🎨 [Frontend] Request Account form for oSPARC 🚨 ⚠️ DEVOPS Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add registration form for the oSPARC product
6 participants