-
Notifications
You must be signed in to change notification settings - Fork 30
🎨 [Frontend] Request Account form for oSPARC 🚨 ⚠️ DEVOPS #6217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Request Account form for oSPARC 🚨 ⚠️ DEVOPS #6217
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6217 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1466 +1456
Lines 214 60943 +60729
Branches 25 2063 +2038
=========================================
+ Hits 181 53710 +53529
- Misses 23 6918 +6895
- Partials 10 315 +305
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thanks!
@JavierGOrdonnez, when this reaches production, you might get a json form in the emails from people who request an osparc account. Just add that to the "Preregistration" tab in the PO Center, or ask @pcrespov for more info. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't run it in the browser but looks ok. I don't expect big surprises
What do these changes do?
If product vendor's information says that
invitation_form
and the login configuration saysinvitation_required
, a Request Account form will be displayed (no moreis_product_billable
checks for this).Related issue/s
closes ITISFoundation/osparc-issues#1584
How to test
"invitation_form": true
in database (see below)"invitation_form": false
to obtain either a link (ifinvitation_url
is provided) or an email (if not)Dev-ops checklist 🚨
invitation_form: true
inproducts.vendor
column of the database. e.g.